Make profile page tabs design responsive

Bug #1253835 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon

Bug Description

Other tabsets respect the responsive design rules - just not this set.

-- reported by Evonne

Revision history for this message
Robert Lyon (robertl-9) wrote :

https://reviews.mahara.org/#/c/2754/
Have added a patch for this

Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2754
Committed: http://gitorious.org/mahara/mahara/commit/b7577ea86920e1b10b6a81a30ccb67664f353cda
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit b7577ea86920e1b10b6a81a30ccb67664f353cda
Author: Robert Lyon <email address hidden>
Date: Wed Nov 27 15:46:46 2013 +1300

Making the profile page tabs work in responsive design (bug #1253835)

Because the profile tabs are created on the fly by javascript in
htdocs/artefact/internal/js/profile.js (which is mochikit) after the
page loads I couldn't use the exact same trick as other places in site.

Insetad I had to add the necessary dom elements and onclick toggle to
the tab block as they were being created.

And then got htdocs/js/rd-nav.js to check for the existance of profile
tab set and if exists deal with it like the others.

I also discovered all the instances where TABS heading was used
happened to be a hardcoded string so tidied that up also

Change-Id: I38a93ec8d06d05daed04406704590b5b1e1ac2fe
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 1.9.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.