editing a skin deletes the creation time from db

Bug #1252497 reported by Robert Lyon on 2013-11-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.8
High
Unassigned
1.9
High
Robert Lyon

Bug Description

To test:

1) Create a new skin
2) Look at the database:
> SELECT id, ctime, mtime FROM skin;

you should see the new skin you made containing both ctime and mtime values (which should be the same)

3) Edit skin
4) Look at the database again:
> SELECT id, ctime, mtime FROM skin;

you should see the new skin you made only containing the new mtime, the ctime is not NULL

this should be fixed soon as data is being lost

Robert Lyon (robertl-9) wrote :

Have made patch for this:
https://reviews.mahara.org/#/c/2715/

Robert Lyon (robertl-9) on 2013-11-19
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/2715
Committed: http://gitorious.org/mahara/mahara/commit/f82a4f624c9c09672c842317c040e0817255ff81
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit f82a4f624c9c09672c842317c040e0817255ff81
Author: Robert Lyon <email address hidden>
Date: Tue Nov 19 11:50:05 2013 +1300

Skin creation date was not being preserved on edit (Bug #1252497)

The creation date was being set to null on edit.
I've added code to preserve the creation date
- and to add new one (last modifed date) if a
skin does not have one (been edited before the patch applied)

Change-Id: I5b66a0ff7dbefde4c35315b4749f1295205cba99
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) wrote :

The fix needs to be forward-ported to 1.9.0

Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) wrote :

Correction, the fix is on the 1.9 branch, and needs to be backported to 1.8

Aaron Wells (u-aaronw) wrote :
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2807
Committed: http://gitorious.org/mahara/mahara/commit/ee47dc6cfd98e86b864db7b80ee3e2ac1e84b228
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit ee47dc6cfd98e86b864db7b80ee3e2ac1e84b228
Author: Robert Lyon <email address hidden>
Date: Tue Nov 19 11:50:05 2013 +1300

Skin creation date was not being preserved on edit (Bug #1252497)

The creation date was being set to null on edit.
I've added code to preserve the creation date
- and to add new one (last modifed date) if a
skin does not have one (been edited before the patch applied)

Change-Id: I5b66a0ff7dbefde4c35315b4749f1295205cba99
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2013-12-18
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers