Give a different error message for an expired registration key than for an invalid registration key
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Wishlist
|
Valerii Kuznetsov |
Bug Description
In the optional self-registration process, users can fill in their email address to register an account, and then Mahara sends them an email with a registration link in it that contains a unique key. They click on that in order to complete the registration process.
The problem is that the code for this checks on two conditions at once, and prints out only one error message for both of them.
if (!$registration = get_record_
}
... and ...
$string[
In https:/
1. Attempt to retrieve the usr_registration record with the matching key.
2. If no record is found, print an error message saying we don't have a key that matches your link, perhaps your email program mangled it?
3. If a usr_registration record is found, compare the value of its "expiry" field with current server time, and if it has expired show the user the message that says "sorry, this key has expired."
summary: |
- Give a separate error message for an expired registration key or an - invalid registration key + Give a different error message for an expired registration key than for + an invalid registration key |
Changed in mahara: | |
assignee: | nobody → Valerii Kuznetsov (valerii-kuznetsov) |
status: | Confirmed → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
milestone: | none → 1.9.0 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Is there maybe the possibility to shorten that link? We've had issues in the past where some email clients put a line break in the link and thus simply clicking it didn't give the proper result. A link that spans two lines is problematic.