"Image gallery" & "Folder" blocks don't show which folder is selected

Bug #1236128 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.5
Fix Released
High
Son Nguyen
1.6
Fix Released
High
Son Nguyen
1.7
Fix Released
High
Son Nguyen

Bug Description

To replicate:

1. In your contents area, create a folder and put some images in it
2. Create a page
3. Put an "Image gallery" block on that page
4. Select your folder
5. Save the block
6. Edit the block again

Expect result: The block config should show you the selected folder
Actual result: The block config shows you the filepicker and doesn't not indicate which folder is selected

Revision history for this message
Aaron Wells (u-aaronw) wrote :

I also verified that this happens for the folder block, and it goes back to Mahara 1.5.

summary: - "Image gallery" block doesn't show which folder is selected
+ "Image gallery" & "Folder" blocks don't show which folder is selected
tags: added: folder
Revision history for this message
Robert Lyon (robertl-9) wrote :

Part of this patch
https://reviews.mahara.org/#/c/2579/

namely the change in htdocs/lib/form/elements/filebrowser.php fixes this problem.

The problem was created by a security change and that ArtefactTypeFolder was not treated the same as ArtefactTypeFile.

And as the security patch was ported back to earlier versions it made it look like the bug was an old one when in fact it was brand new :)

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Well shoot, it looks like we'll need to do one more 1.5 release, in order to fix this regression. :-P

We should review all the code changes in f1db0886ab876950e9fe031c65b30dd97d15bf70 to see if we made the mistake in other places. For instance, in artefact/file/blokctype/gallery/lib.php (since a gallery can take a Folder I think), and maybe in blocktype/lib.php.

Cheers,
Aaron

Aaron Wells (u-aaronw)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
tags: added: regression
Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Here's the patch for 1.7: https://reviews.mahara.org/#/c/2585/

Revision history for this message
Aaron Wells (u-aaronw) wrote :

This bug was spun off from https://bugs.launchpad.net/mahara/+bug/1235305 . The patch is based on the patch for that bug.

Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
Son Nguyen (ngson2000)
no longer affects: mahara/1.5
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2655
Committed: http://gitorious.org/mahara/mahara/commit/7bda07eb09ef563035ffab14aa7a3df561f35037
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.6_STABLE

commit 7bda07eb09ef563035ffab14aa7a3df561f35037
Author: Robert Lyon <email address hidden>
Date: Mon Oct 7 12:49:58 2013 +1300

Problems with image gallery and file/folder selection
Bug 1236128

Folder was not staying selected when re-editing the block
due to it being not ArtefactTypeFile - have adjusted the check to
include ArtefactTypeFolder as well

Change-Id: I9b8cbe786b0d35109f05a664f04665e9a9967d92
Signed-off-by: Aaron Wells <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2656
Committed: http://gitorious.org/mahara/mahara/commit/fd4949f9b109c4c9355b974fd21f960439c2e0ae
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.5_STABLE

commit fd4949f9b109c4c9355b974fd21f960439c2e0ae
Author: Robert Lyon <email address hidden>
Date: Mon Oct 7 12:49:58 2013 +1300

Problems with image gallery and file/folder selection
Bug 1236128

Folder was not staying selected when re-editing the block
due to it being not ArtefactTypeFile - have adjusted the check to
include ArtefactTypeFolder as well

Change-Id: I9b8cbe786b0d35109f05a664f04665e9a9967d92
Signed-off-by: Aaron Wells <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers