MNet with port number requires port to be in wwwroot

Bug #1220410 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Yuliya Bozhko

Bug Description

When a Moodle site sits on a different port, the port number needed to be included in the wwwroot. The "Port" field was pretty much ignored.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Hi Kristina,

Taking a quick peek at the code, I can see that the port number field on the XMLRPC screen is never used anywhere. It's stored in the DB, and then entirely ignored.

I think we should probably just delete this field entirely. Since it's not currently in use, that won't cause any problems to any existing users.

Cheers,
Aaron

Changed in mahara:
importance: Undecided → Low
tags: added: bite-sized
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Thanks for checking, Aaron. Sounds good to me.

Changed in mahara:
assignee: nobody → Yuliya Bozhko (yuliya.bozhko)
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/2986

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2986
Committed: http://gitorious.org/mahara/mahara/commit/fe2964ab8792efc2689addb84db747384967c82f
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit fe2964ab8792efc2689addb84db747384967c82f
Author: Yuliya Bozhko <email address hidden>
Date: Wed Feb 5 14:46:47 2014 +1300

Remove unused port number from XMLRPC auth (Bug #1220410)

Change-Id: I87ec616b0d27d9c168ad0233457ac6feec94301c
Signed-off-by: Yuliya Bozhko <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: none → 1.9.0
tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.