Linking of tags in tag search

Bug #1196213 reported by Kristina Hoeppner on 2013-06-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon
1.8
Low
Unassigned
1.9
Low
Robert Lyon

Bug Description

The first site administrator of a site sees tags linked on /tags.php. However, regular users do not have their tags linked on that page. Every other user does not have the tags linked, not even a user who is newly created and has site admin rights.

Mahara master (1.8.0dev)

Aaron Wells (u-aaronw) on 2013-07-01
Changed in mahara:
milestone: none → 1.8.0rc1
Aaron Wells (u-aaronw) on 2013-09-30
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw) on 2013-10-22
Changed in mahara:
milestone: 1.8.0 → 1.8.1
Robert Lyon (robertl-9) wrote :

Turns out the showing of the links was hardcoded to only show for owner = 1.
I've added patch to make it show the link if the owner of the tags matches the current owner
https://reviews.mahara.org/#/c/2734/

Changed in mahara:
status: Triaged → In Progress
assignee: nobody → Robert Lyon (robertl-9)

Reviewed: https://reviews.mahara.org/2734
Committed: http://gitorious.org/mahara/mahara/commit/2125398d94f21b1f145a23dc9ae8c5e3216d0be2
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 2125398d94f21b1f145a23dc9ae8c5e3216d0be2
Author: Robert Lyon <email address hidden>
Date: Fri Nov 22 08:48:22 2013 +1300

Tag links now for current owner not just owner = 1 (bug #1196213)

Change-Id: Id8b24afcd7dcfc315b1f62cf70e57de289ba784f
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2013-12-17
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) wrote :
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2821
Committed: http://gitorious.org/mahara/mahara/commit/f414db2d102d1fb492b56bf15ce575453f655b1e
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit f414db2d102d1fb492b56bf15ce575453f655b1e
Author: Robert Lyon <email address hidden>
Date: Fri Nov 22 08:48:22 2013 +1300

Tag links now for current owner not just owner = 1 (bug #1196213)

Change-Id: Id8b24afcd7dcfc315b1f62cf70e57de289ba784f
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2013-12-18
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers