Forum post deletion notices should not count towards pagination
Bug #1127802 reported by
Melissa Draper
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Confirmed
|
Medium
|
Unassigned |
Bug Description
In addition to bug #1127801, post removal notices should be ignored by the pagination.
Even if bug #1127801 is implemented, several spammers flooding a topic might take turns and hence stop the consecutive grouping from being successful in reducing the noise.
description: | updated |
Changed in mahara: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Aaron Wells (u-aaronw) |
Changed in mahara: | |
assignee: | Aaron Wells (u-aaronw) → nobody |
To post a comment you must log in.
Note that this turns out to be a difficult thing to implement without getting rid of the LIMIT function on the query that selects the forum entries for the page. You'd need to group together adjacent deleted records by the same author, something which is probably only possible with a window function: http:// www.postgresql. org/docs/ 9.1/static/ tutorial- window. html
So, one might implement this as a postgres-only bit of functionality.
Alternately, just drop the LIMIT function from the query that gets the forum records, and in PHP process through them all to find the 10 unique non-deleted records for the page. If you use adodb recordsets for this instead of dumping the recordset into an array, you won't have to worry about running out of memory. There just might be some processing time involved, if you're dealing with a giant thread.