Allow uploading attachments to Textboxes/Notes

Bug #1117237 reported by Gregor Anželj
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gregor Anželj

Bug Description

After implementing the otion to add attachments to Resume composites, the discussion about adding the option for users to upload attachments to individual Textboxes/Notes, has started. Apparently a lot of users want to attach files (especially images) to their textboxes/notes.

Changed in mahara:
assignee: nobody → Gregor Anželj (gregor-anzelj)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
tags: removed: whishlist
tags: added: nominatedfeature
Changed in mahara:
milestone: none → 1.8.0rc1
importance: Medium → Wishlist
Revision history for this message
Aaron Wells (u-aaronw) wrote :
Revision history for this message
Aaron Wells (u-aaronw) wrote :

I updated the code in gerrit to use the standard filebrowser pieforms element on the text box block pop-up.

The only thing I couldn't get working was the TinyMCE plugin to let a user select one of the attached files, while in the block pop-up. You can use it if you create/edit a note via the Notes page, but doing it within the pop-up was more complicated. Since that's kind of an obscure feature, I'm going to leave it for a later bug.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

I noticed that note attachments weren't getting properly attached after re-importing from leap2a, so I've taken care of that as well.

Revision history for this message
Aaron Wells (u-aaronw) wrote :
Revision history for this message
Gregor Anželj (gregor-anzelj) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2252
Committed: http://gitorious.org/mahara/mahara/commit/37e235333bd7ff7335c25cddaec5ac7efbdfd298
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 37e235333bd7ff7335c25cddaec5ac7efbdfd298
Author: Aaron Wells <email address hidden>
Date: Thu May 30 14:12:17 2013 +1200

Make pieforms fieldset element's "views_js" function recursive

Bug 1117237: Make it so that we include the views_js from the fieldset's elements

Change-Id: Ia41cc4114b03256329ce6147c2330f3e5c31e48e

Revision history for this message
Steven (stevens-q) wrote :

Catalyst QA Testing

=== Tested for ===
1. Confirm that note attachments weren't getting properly attached after re-importing from leap2a ✔
2. confirm that files are able to be attached to text boxes on Profile pages ✔
3. confirm that files changed on a copy of a text box, all other original text boxes get changed ✔
4. confirm that you can remove a file from a publihsed text box ✔

=== Test Results ===
1. Saved profile - all data to a LEAP2A file and added a new user from the newly created LEAP2A file - all attachments to text boxes is still there and working ✔

=== Bugs ===
1. When a user is adding files and wants to choose a file from another folder the leave page (dirty Page) warning appears
        a. when selecting leave page - the page remains as before but I now have access to my files within that folder
<<<EXPECTED RESULT - not to have this functionality when on the same page>>>
 b. selecting other folders does not cause the leave page warning to display after the inital warning
2. When duplicating a text box - the title still uses the original title Not the latest title

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2255
Committed: http://gitorious.org/mahara/mahara/commit/22c0bde5bf0016f41f3370e370bbf3a197559226
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 22c0bde5bf0016f41f3370e370bbf3a197559226
Author: Aaron Wells <email address hidden>
Date: Thu May 30 19:19:18 2013 +1200

Leap2a: Add support for standalone Notes and their Attachments Bug#1117237

The exportation and importation of attachments for text boxes should
be working correctly.

The exportation of attachment files for resume options should be working
- however the leap2a dat afor them is not quite correct

The leap2a importation should upload the resume attachment files and
place them in Contens -> files.
- however it is not currently attaching them to the resume entry, the
artefact_attachment table is not getting updated correctly.

TO DO: get the <link rel="related" href="portfolio:artefact?"/> to
be in correct part of xml file and also be able to save the item id to
the table as well

Change-Id: Ibda0fcc85265c458a59738f2c69e712b7324d445
Signed-off-by: Aaron Wells <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers