Aaron hi.

I agree with you that #1 and #2 should be easily fixed.

About #3 and #4:

I've also implemented Mahara filepicker widget for Textbox/Notes
attachments (see: https://reviews.mahara.org/#/c/2029/).
It uses/implements standard Mahara filepicker, but...

...but:
- it worked on previous version of Mahara (1.6.x) and it doesn't work for
1.7.x. I guess there are Javascript issues that I cannot overcome.
- tried to implement this also for E&E etc but they also got a lot of their
internal Javascript (Resume composite stuff) and I don't even know where to
begin to merge/accomodate? Javascript code for Resume composite stuff and
Mahara file picker so there would not be any conflicts and that eveything
would work.

I'm currently just not that good at Javascript. Maybe you could help?

Please see the upper commit link to get the idea. Maybe worth exploring...

HTH, Gregor


2013/5/23 Aaron Wells <email address hidden>

> Thanks very much for providing this code, Gregor! :) And I'm sorry it
> took us so long to get around to reviewing it.
>
> The basic functionality works: I am able to attach files to items in my
> Achievements, Education, and Employment sections of my resume. These
> attachments are then listed with download links if I list those resume
> sections on one of my pages. They also show up under the Content/Files
> page, in a new directory called "resumefiles".
>
> I do notice a few issues, though:
>
> 1. When I'm on the screen that lists my Achievements (or E&E) (i.e.
> /artefact/resume/employment.php ), and I mouse over the paperclip icon
> at the top of the column that say how many attachments each item has,
> the mouse pointer changes to one that indicates it's a clickable link,
> even though it isn't. (This is probably a CSS styling issue)
>
> 2. On that same list screen ( /artefact/resume/employment.php ), when I
> click on one of my achievements' names to view its description, the list
> of attachments is also shown, but the attachments are only named, not
> shown with a clickable link, so I can't tell what's in them easily.
>
> 3. The resume item editing screen (
> /artefact/resume/editcomposite.php?id=2&artefact=5 ) only lets you add
> items; it doesn't let you remove them or re-order them, or tell you
> which ones you've already attached.
>
> 4. The mechanism to add files is a simple file upload button, so you
> can't pick files you've already uploaded into Mahara.
>
> 5. Again on the item editing screen, if I've attached a series of files
> but left out one of the required fields so that the form fails
> validation, the reloaded form will be lacking all the files I've just
> attached.
>
> I'm not sure that these problems are all necessarily blockers... as I
> said before, the code works. It might be worthwhile to take an
> incremental approach. Which is to say, upstream this code with these
> non-blocker issues so at least it gets out there, and then come back and
> fix them as we have the resources to do so.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1103942
>
> Title:
>   Allow uploading attachments to Resume composites
>
> Status in Mahara ePortfolio:
>   In Progress
>
> Bug description:
>   Add the option for users to upload attachments to each item of  any of
>   the Resume composites (Eduaction history, Employment history,
>   Certifications, Books and Memberships).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mahara/+bug/1103942/+subscriptions
>



-- 
----------
Gregor Anželj, prof.
Gimnazija Bežigrad, Ljubljana