cleanurl's only checks !is_null, but a urlid could be ''

Bug #1095934 reported by Hugh Davenport
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Son Nguyen

Bug Description

group_homepage_url lib/group.php line 2351

There was a problem where the links only showed /group/, but no id, I think this is to do with the $group->urlid being '', which is not null, but empty. I suggest using empty instead.

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

Doesn't happen when you regenerate the cleanurl's

Changed in mahara:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Note for Kristina to remember it better when we get to it: That was an issue we found during the upgrade of mahara.org to 1.7.0dev in January 2013. The "Mahara Community" group didn't have an ID whereas all other groups had.

Son Nguyen (ngson2000)
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2800
Committed: http://gitorious.org/mahara/mahara/commit/2f41bf3c10974b1c537236e9390bf28ae8ba4202
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2f41bf3c10974b1c537236e9390bf28ae8ba4202
Author: Son Nguyen <email address hidden>
Date: Mon Dec 16 09:28:43 2013 +1300

Using empty() instead of is_null (Bug 1095934)

Change-Id: I32cf198a8fa33a9e9773a752c6b32ce5fa079c7b
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.