Mahara

Link to user profile takes on comment ID

Bug #1085569 reported by Kristina Hoeppner
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Melissa Draper
Mahara 1.7.0
1.6
Fix Released
Undecided
Melissa Draper
Mahara 1.6.3

Bug Description

When a user comments on a page for example, the link displayed for the user profile is actually the comment ID.

Reported at https://mahara.org/interaction/forum/topic.php?id=5109 and confirmed on demo.mahara.org

You can test this easily by commenting on a page and then hovering over the link of the user profile. It is not the one of the user, but the comment. You can verify that by going to "Shared pages" and hovering over the link "View comment".

Tags: bite-sized
Melissa Draper (melissa)
Changed in mahara:
milestone: none → 1.6.3
milestone: 1.6.3 → 1.7.0
no longer affects: mahara/1.7
Melissa Draper (melissa)
no longer affects: mahara/1.5
Melissa Draper (melissa)
Changed in mahara:
assignee: nobody → Melissa Draper (melissa)
Son Nguyen (ngson2000)
tags: added: bite-sized
Revision history for this message
Son Nguyen (ngson2000) wrote :

Change $item to $item->author, at the line 497, /artefact/comment/lib.php

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

also reported at https://bugs.launchpad.net/mahara/+bug/1095221 (marked as duplicate there)

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

https://reviews.mahara.org/1899
https://reviews.mahara.org/1900

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1899
Committed: http://gitorious.org/mahara/mahara/commit/d2528d0071f7f4416cc64c3c75e62fe3eca2f9d6
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.6_STABLE

commit d2528d0071f7f4416cc64c3c75e62fe3eca2f9d6
Author: Melissa Draper <email address hidden>
Date: Mon Dec 3 20:42:53 2012 +1300

    Fix regression in user link display for feedback (Bug #1085569)

    In cleanurls commit 0d28fabc9264f2051a4a9829c7730d9d40900ca5 the
    item object rather than the author id was passed to the profile_url
    method.

    Change-Id: I0cf818e57171d63bd07eee372fbacc7accf787ca

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1900
Committed: http://gitorious.org/mahara/mahara/commit/9449fc4c6ee6684887478f18ebc0f2672014460f
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 9449fc4c6ee6684887478f18ebc0f2672014460f
Author: Melissa Draper <email address hidden>
Date: Mon Dec 3 20:42:53 2012 +1300

    Fix regression in user link display for feedback (Bug #1085569)

    In cleanurls commit 0d28fabc9264f2051a4a9829c7730d9d40900ca5 the
    item object rather than the author id was passed to the profile_url
    method.

    Change-Id: I0cf818e57171d63bd07eee372fbacc7accf787ca

Ali Kaye (alexandrakaye-student)
Changed in mahara:
status: Triaged → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.