rss fails to update feeds

Bug #1081431 reported by Melissa Draper on 2012-11-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Melissa Draper
1.5
High
Melissa Draper

Bug Description

The lastupdate values in the database were all nulled with a recent update and hence now ignored by the rss cron job

Reviewed: https://reviews.mahara.org/1831
Committed: http://gitorious.org/mahara/mahara/commit/1bde7f251e707792274c6f70b7cbb4575447ccb2
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit 1bde7f251e707792274c6f70b7cbb4575447ccb2
Author: Melissa Draper <email address hidden>
Date: Mon Oct 29 16:56:04 2012 +1300

    Fix the rss image exceptions preventing updating (Bug #1081431)

    Check the image data is a string (eg url) or array before
    proceeding, and set data to null if not.

    Serialising is the only way to check if a value can be unserialised
    so @ is suppressing the warnings thrown by non-unserialisable data.

    Prevent the issue happening in future installs, and fix current
    installs.

    Change-Id: I05c88f95e2f511e491bcbd5fa40d3c41949eff7f
    Signed-off-by: Melissa Draper <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1883
Committed: http://gitorious.org/mahara/mahara/commit/12278823ae62a11928f79eaee7cde16016592818
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.5_STABLE

commit 12278823ae62a11928f79eaee7cde16016592818
Author: Melissa Draper <email address hidden>
Date: Mon Oct 29 16:56:04 2012 +1300

    Fix the rss image exceptions preventing updating (Bug #1081431)

    Check the image data is a string (eg url) or array before
    proceeding, and set data to null if not.

    Serialising is the only way to check if a value can be unserialised
    so @ is suppressing the warnings thrown by non-unserialisable data.

    Prevent the issue happening in future installs, and fix current
    installs.

    Change-Id: I05c88f95e2f511e491bcbd5fa40d3c41949eff7f
    Signed-off-by: Melissa Draper <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1957
Committed: http://gitorious.org/mahara/mahara/commit/747ffb0827884714c9aa2a7e8e3c56bccbc4499d
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.5_STABLE

commit 747ffb0827884714c9aa2a7e8e3c56bccbc4499d
Author: Melissa Draper <email address hidden>
Date: Wed Dec 5 12:54:15 2012 +1300

    Additional processing fixes for rss to avoid fatal errors (Bug #1081431)

    Checking for the datatypes returned, and catching exception caused
    by a previous exception object getting passed to the database,
    which adodb doesn't know what to do with, surprisingly enough.
    Making use of try to better handle failing record updates.

    Change-Id: Ia493ca433b7046db1afcdf80bd754ca6d2ebdc40
    Signed-off-by: Melissa Draper <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1956
Committed: http://gitorious.org/mahara/mahara/commit/386dd43759563ed5dbda084b5ecc4243d5f936da
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit 386dd43759563ed5dbda084b5ecc4243d5f936da
Author: Melissa Draper <email address hidden>
Date: Wed Dec 5 12:54:15 2012 +1300

    Additional processing fixes for rss to avoid fatal errors (Bug #1081431)

    Checking for the datatypes returned, and catching exception caused
    by a previous exception object getting passed to the database,
    which adodb doesn't know what to do with, surprisingly enough.
    Making use of try to better handle failing record updates.

    Change-Id: Id211efe045da6182f1316cb60888711f4063a52d
    Signed-off-by: Melissa Draper <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1955
Committed: http://gitorious.org/mahara/mahara/commit/129e26277596cde05de2048988112e571bc964ef
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit 129e26277596cde05de2048988112e571bc964ef
Author: Melissa Draper <email address hidden>
Date: Tue Jan 15 11:34:06 2013 +1300

    Additional processing fixes for rss to avoid fatal errors (Bug #1081431)

    Checking for the datatypes returned, and catching exception caused
    by a previous exception object getting passed to the database,
    which adodb doesn't know what to do with, surprisingly enough.
    Making use of try to better handle failing record updates.

    Change-Id: I884021aca8d3cb416acab575151ed97d7d64d3ed
    Signed-off-by: Melissa Draper <email address hidden>

Rocky YIP (rockyip-ied) wrote :

I am using version 1.6.1 and having the same problem that cron.php does not update RSS feed.

I try to apply the fixes but RSS feed still cannot get updated.

Best Rgds,

Rocky.

Melissa Draper (melissa) wrote :

Hi Rocky,

What is preventing the updating? Are there fatal errors in your apache error logs? I can't suggest anything without that information.

Melissa Draper (melissa) on 2013-02-19
Changed in mahara:
status: Confirmed → Fix Released
Melissa Draper (melissa) on 2013-02-19
no longer affects: mahara/1.7
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers