when editing a file download artefact and the licence acceptance is on, the entire screen is used

Bug #1051844 reported by Hugh Davenport on 2012-09-17
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nigel Cunningham
Nigel Cunningham

Bug Description

using chrome 21.0.1180.89 Debian wheezy/sid (154005)

It uses the entire screen, whereas I would think it should use a text wrap and use the normal size (without the agreement).

Hugh Davenport (hugh-davenport) wrote :

Designer has said that is to do with js using a calculated px for width, it should be changed to have %

Changed in mahara:
assignee: nobody → Hugh Davenport (hugh-catalyst)
Melissa Draper (melissa) on 2012-09-27
Changed in mahara:
status: Triaged → Incomplete
milestone: 1.6.0 → 1.7.0
Changed in mahara:
status: Incomplete → Confirmed
Aaron Wells (u-aaronw) on 2013-04-19
Changed in mahara:
milestone: 1.7.0 → 1.8.0
Aaron Wells (u-aaronw) on 2013-09-30
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw) on 2013-10-22
Changed in mahara:
milestone: 1.8.0 → 1.8.1
Aaron Wells (u-aaronw) on 2013-12-16
Changed in mahara:
milestone: 1.8.1 → 1.8.2
Robert Lyon (robertl-9) on 2014-04-03
Changed in mahara:
milestone: 1.8.2 → 1.8.3
Aaron Wells (u-aaronw) on 2014-05-13
Changed in mahara:
milestone: 1.8.3 → 1.9.2
Robert Lyon (robertl-9) on 2014-07-31
Changed in mahara:
milestone: 1.9.2 → 1.9.3

It is still an issue also in Mahara 1.10 dev.

Steps to replicate:

1. Turn on the upload agreement in Admin -> Plugins -> File configuration.
2. Add any file block. I added the image block and got the attached result in "mahara-1-10_image_license_acceptance_on.png".
3. Turn off the upload agreement.
4. Add any file block. I added the image block and got the attached result in "mahara-1-10_image_license_acceptance_off.png", which is the pop-up in the regular width.

Changed in mahara:
milestone: 1.9.3 → 1.10.0
assignee: Hugh Davenport (hugh-davenport) → nobody
no longer affects: mahara/1.10
no longer affects: mahara/1.9

Reviewed: https://reviews.mahara.org/3728
Committed: http://gitorious.org/mahara/mahara/commit/141ee71b4a56c14023a7b3f2b7932934895bce0c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 141ee71b4a56c14023a7b3f2b7932934895bce0c
Author: Nigel Cunningham <email address hidden>
Date: Mon Dec 29 09:30:10 2014 +1100

Bug1051844: Fix block configure dialog width.

The configure dialog for blocks is currently set to a fixed width via
Javascript, but there is no handler for browser resizing and it results in the
dialogue being very wide for the sake of just one line when a license agreement
is enabled.

Fix this issue by making all dimensions percentages, and using a combination of
max-width: 90% and width: max-content. In addition, make the dialog fixed
position with its own scrollbars as needed (the body's scrollbar is disabled
when the dialog is shown).

Contextual help's width code and CSS is also adjusted so that it wraps within
dialog boxes rather than pushing the width out.

Change-Id: If2a40739f1510cedcf9a6133ccfb8f0a18257356

Robert Lyon (robertl-9) wrote :

The refactoring of the configure form popup is now controlled via css and is far more flexible - allowing for resizing the screen and the configure block adjusting accordingly.

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers