date-limited groups

[Jiri Baum (Catalyst)]

It would be nice to have date limits on groups, so that members can only post within a certain time period.

[Jiri Baum (Catalyst) (jiri-catalyst)]

Patch is now up on gerrit.

https://reviews.mahara.org/1367

[Jiri Baum (Catalyst) (jiri-catalyst)]

Rebased on master and resubmitted to gerrit.

https://reviews.mahara.org/1368

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1391
Committed: http://gitorious.org/mahara/mahara/commit/14907d60a54ca6781a1255eab5fccc55b4df2016
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 14907d60a54ca6781a1255eab5fccc55b4df2016
Author: Darrin Hodges and Nathan Mares and Jiri Baum <email address hidden>
Date: Mon Jul 2 14:58:13 2012 +1000

    Date limits for groups (bug #1017354) - obey limits

    Add date limits (from-until) to groups; members will only be able to make
    changes in the group during the specified time period.

    This commit restricts user access to within the date limits.

    Change-Id: I4574ad724d87fbaeb72063d952741114f8ea8d85
    Signed-off-by: Jiri Baum <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1390
Committed: http://gitorious.org/mahara/mahara/commit/5eef6992f503d12e73022047b953a80bc7f4a87a
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 5eef6992f503d12e73022047b953a80bc7f4a87a
Author: Darrin Hodges and Nathan Mares and Jiri Baum <email address hidden>
Date: Mon Jul 2 15:00:07 2012 +1000

    Date limits for groups (bug #1017354) - view/edit

    Add date limits (from-until) to groups; members will only be able to make
    changes in the group during the specified time period.

    This commit adds support for viewing and editing the date limits.

    Change-Id: Ic37124dbb36c104e9771ae7859393076480214be
    Signed-off-by: Jiri Baum <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1389
Committed: http://gitorious.org/mahara/mahara/commit/dca581abe40123062e2f3a9be4cdc6bd32b04a04
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit dca581abe40123062e2f3a9be4cdc6bd32b04a04
Author: Darrin Hodges and Nathan Mares and Jiri Baum <email address hidden>
Date: Mon Jul 2 14:59:52 2012 +1000

    Date limits for groups (bug #1017354) - date/time

    Add date limits (from-until) to groups; members will only be able to make
    changes in the group during the specified time period.

    This commit adds support for showing the time along with dates.

    Change-Id: Ic1c7771febd97d5eb564da0af2a45b2bca7a01f2
    Signed-off-by: Jiri Baum <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1368
Committed: http://gitorious.org/mahara/mahara/commit/8ccabebdcd99811ef5df91bcd78fe5e24cd9189a
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 8ccabebdcd99811ef5df91bcd78fe5e24cd9189a
Author: Darrin Hodges and Nathan Mares and Jiri Baum <email address hidden>
Date: Mon Jul 2 14:50:25 2012 +1000

    Date limits for groups (bug #1017354) - add fields

    Add date limits (from-until) to groups; members will only be able to make
    changes in the group during the specified time period.

    This commit adds the date limit fields to the database schema.

    Change-Id: I9feb44b247a8614020540102a30e595308f96f00
    Signed-off-by: Jiri Baum <email address hidden>

[Dominique-Alain JAN (dajan)]

After having git pull to the latest dev version, I get the date limit option for group, but I have the text

[[element.date.at/pieforms]] that is shown on my page instead of the calendar or another piece of interface (I presume).

See attachment
-dajan

[Jiri Baum (Catalyst) (jiri-catalyst)]

@dajan, looks like we didn't get the i18n quite right there... The text [[element.date.at/pieforms]] should be something to indicate that the two numbers that follow are hour and minute.

[Hugh Davenport (hugh-davenport)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I remembered seeing this in review, but forgot to mention it.

Patch at https://reviews.mahara.org/1478

Cheers,

Hugh

On 07/08/12 11:38, Jiri Baum (Catalyst) wrote:
> @dajan, looks like we didn't get the i18n quite right there... The
> text [[element.date.at/pieforms]] should be something to indicate
> that the two numbers that follow are hour and minute.
>

- --
Hugh Davenport
[phone]
Developer
Catalyst IT Ltd.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlAhiokACgkQuMoJ2LQ3zxEv0gP+Pg4ZG+qKwpJ8aydENHkUK+dI
fCSpTPgKs+Ge3Izl6RlrF9lfKiLH0r1cVNBqKCI3EWw2Zg8qwtklnuaij1PHPUyS
jJFam76hYrGLtR4HLhQ1mP9esF/iONDVYYot721BKEmXXT2zTjTAw02FEPgPW4SN
BKTvEHS6I09EKxMxNu0=
=UNAz
-----END PGP SIGNATURE-----

[Hugh Davenport (hugh-davenport)]

See bug #1036800 for the lang string

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1478
Committed: http://gitorious.org/mahara/mahara/commit/8c59370639913f66d94ee901e3e0a548f4e338a1
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit 8c59370639913f66d94ee901e3e0a548f4e338a1
Author: Hugh Davenport <email address hidden>
Date: Wed Aug 8 09:35:09 2012 +1200

    Add string for seperating time and date (Bug #1017354)

    Change-Id: Ibb89b438fdd0c61ee02ab1e1036ed81e2e74bd0c
    Signed-off-by: Hugh Davenport <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1537
Committed: http://gitorious.org/mahara/mahara/commit/da24f3737c73f5bb9d8f7548f0d3cc11d8c8fc0c
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit da24f3737c73f5bb9d8f7548f0d3cc11d8c8fc0c
Author: Hugh Davenport <email address hidden>
Date: Wed Aug 8 09:35:09 2012 +1200

    Add string for seperating time and date (Bug #1017354)

    Change-Id: Ibb89b438fdd0c61ee02ab1e1036ed81e2e74bd0c
    Signed-off-by: Hugh Davenport <email address hidden>

[Kristina Hoeppner (kris-hoeppner)]

I have a couple of issues around the lang strings (sorry that I didn't see this more clearly earlier):

1. Why are all strings under Editability in italics? No others are. These should just be like all the others.
2. At minimum, the strings "Group cannot be edited by members before this date" / "...after this date" are not found in the lang strings, but hardcoded in /group/edit.php. That should be corrected so that these strings can also be translated.

Please also check if there are any other strings that would need to make translatable.

[Kristina Hoeppner (kris-hoeppner)]

Ignore my first question. I did see other date limited things now also in italics. But item #2 is still correct I think.

[Kristina Hoeppner (kris-hoeppner)]

And with "correct" I mean "needs fixing" ;-)

[Hugh Davenport (hugh-davenport)]

bug #1039766

[Jiri Baum (Catalyst) (jiri-catalyst)]

On 21/08/12 05:07, Kristina Hoeppner wrote:
> And with "correct" I mean "needs fixing" ;-)

Patch now up on gerrit.

https://bugs.launchpad.net/bugs/1039766
https://reviews.mahara.org/1550

Jiri
--
Jiří Baum <email address hidden>

[Jiri Baum (Catalyst) (jiri-catalyst)]

Patch for another missing i18n string, plus passing parameters to a couple of others rather than concatenating.

https://reviews.mahara.org/1630

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1630
Committed: http://gitorious.org/mahara/mahara/commit/d240a2f041969e487c3cc8620aff7e7d29409491
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit d240a2f041969e487c3cc8620aff7e7d29409491
Author: Jiri Baum <email address hidden>
Date: Tue Sep 4 16:21:28 2012 +1000

    Better i18n for group editability date window strings (Bug #1017354).

    * A stray "and" that wasn't translated, plus pass parameters rather than concatenating.
    * Additional to bug #1017354.

    Change-Id: Ibe19359bc0b7bb6f6a753f86191d66f0610dc69e
    Signed-off-by: Jiri Baum <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1633
Committed: http://gitorious.org/mahara/mahara/commit/abc921de6c4fe30287280ab06719572d137d5fbf
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.6_STABLE

commit abc921de6c4fe30287280ab06719572d137d5fbf
Author: Jiri Baum <email address hidden>
Date: Tue Sep 4 16:21:28 2012 +1000

    Better i18n for group editability date window strings (Bug #1017354).

    * A stray "and" that wasn't translated, plus pass parameters rather than concatenating.
    * Additional to bug #1017354.

    Change-Id: Ibe19359bc0b7bb6f6a753f86191d66f0610dc69e
    Signed-off-by: Jiri Baum <email address hidden>

[Hugh Davenport (hugh-davenport)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----