Too many admin notifications about notification failures

[Richard Mansfield]

When a notification method throws an exception, Mahara tries to notify all the site admins to warn them that a "User notification error was probably caused by your server configuration."

This can fill up the notification_internal_activity table. The number of these messages can be reduced by not trying to notify the admins when the admin notification itself fails, and by sending them once only per cron run.

See https://mahara.org/interaction/forum/topic.php?id=3829 and https://mahara.org/interaction/forum/topic.php?id=4578

[Richard Mansfield (richard-mansfield)]

https://reviews.mahara.org/1303
https://reviews.mahara.org/1304

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1304
Committed: http://gitorious.org/mahara/mahara/commit/043024552fa28f29c8feeb1ddfa0a3da74b967ec
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 043024552fa28f29c8feeb1ddfa0a3da74b967ec
Author: Richard Mansfield <email address hidden>
Date: Wed Jun 6 15:39:24 2012 +1200

    Cut down on similar failed notification notifications (bug #1009301)

    When trying to notify the site admins about notification failures,
    drop similar notifications during a single cron run.

    Change-Id: Idcaecd01fcbfd035d57e967d4e9ac10efeb75180
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1303
Committed: http://gitorious.org/mahara/mahara/commit/8826dbf0e50e838b6e400393167377aefeee7690
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 8826dbf0e50e838b6e400393167377aefeee7690
Author: Richard Mansfield <email address hidden>
Date: Wed Jun 6 14:45:37 2012 +1200

    Don't recursively notify admins about notification exceptions (bug #1009301)

    Avoid stupid attempts to notify admins about failed notifications when
    we're in the middle of notifying the admins about failed
    notifications.

    Change-Id: I50037d93e3caf32e8de116cbd638fe5563957ce1
    Signed-off-by: Richard Mansfield <email address hidden>

[Hugh Davenport (hugh-davenport)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----