Mago always returns 0

Bug #444608 reported by Robert Collins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mago
Confirmed
Medium
Unassigned

Bug Description

We had a test suiite in a package, and due to some other mago bug the tests were not found. However mago returned status 0, that it was 'ok' - and this meant 'make distcheck' was passing without running the tests.

We'd like mago to error when no tests are found, so that this case is avoided.

Ara Pulido (ara)
Changed in mago:
importance: Undecided → Medium
assignee: nobody → Ara Pulido (apulido)
status: New → Triaged
Revision history for this message
Ara Pulido (ara) wrote :

In certain case, mago tests are used in a make distcheck environment.

Mago should return other than 0 when:

* No tests are found
* At least on test case failed

This should be double checked with the checkbox integration before committing any change.

summary: - when tests are not found, mago should error
+ Mago always returns 0
Ara Pulido (ara)
Changed in mago:
status: Triaged → Confirmed
assignee: Ara Pulido (apulido) → nobody
Revision history for this message
Marc Tardif (cr3) wrote :

The checkbox integration wraps mago in such a way that the status from running a test is only extracted from the generated xml file, and the return value is simply ignored. So, it should be safe to implement the proposed change.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.