etcd_lb: incorrect listener_type

[Javier Castillo]

In file drivers/swarm_fedora_atomic_v1/templates/cluster.yaml, etcd_lb has hardcoded HTTP protocol:

  etcd_lb:
    type: ../../common/templates/lb.yaml
    properties:
      fixed_subnet: {get_attr: [network, fixed_subnet]}
      external_network: {get_param: external_network}
      protocol: HTTP
      port: 2379

but protocol should be: {get_param: loadbalancing_protocol}

[Wang Bo (chestack)]

it has been fixed for CoreOS and k8s in bug: https://bugs.launchpad.net/magnum/+bug/1679724

[Javier Castillo (javcasalc)]

It is not fixed for swarm clusters.

 https://bugs.launchpad.net/magnum/+bug/1679724 -> fixed only for K8S.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/507820

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507820
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=8f74906435262caea9384a612e23122336a19a12
Submitter: Zuul
Branch: master

commit 8f74906435262caea9384a612e23122336a19a12
Author: Javier Castillo Alcíbar <email address hidden>
Date: Wed Sep 27 13:03:20 2017 +0200

    [swarm-fedora-atomic] fix cluster etcd_lb protocol definition

    In file drivers/swarm_fedora_atomic_v1/templates/cluster.yaml,
    etcd_lb protocol is hardcoded:

      etcd_lb:
        type: ../../common/templates/lb.yaml
        properties:
          fixed_subnet: {get_attr: [network, fixed_subnet]}
          external_network: {get_param: external_network}
          protocol: HTTP
          port: 2379

    but protocol should be: {get_param: loadbalancing_protocol}

    Change-Id: Ib36ff0a99e219db9c0e0f35267faf317f5a14554
    Closes-Bug: #1712054

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/magnum 6.0.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Feilong Wang (<email address hidden>) on branch: master
Review: https://review.opendev.org/497725
Reason: Hi, magnum team is trying to clean up these old pending patches. Please feel free to reopen this if you're still working on. Thanks.