Remove method CORS.set_latent

Bug #1707151 reported by ChangBo Guo(gcb)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
ChangBo Guo(gcb)
Zun
Fix Released
Undecided
ChangBo Guo(gcb)
octavia
Fix Released
Medium
Rajat Sharma
oslo.middleware
Fix Released
Undecided
Unassigned

Bug Description

Method set_latent is deprecated in favor of method set_defaults in e9c3a23e845d8c53b266a3b2e4ca7fb0a5a0425a. We need remove the usage of method set_latent

Revision history for this message
ChangBo Guo(gcb) (glongwave) wrote :

There are two kinds of usage for set_latent

1) Use set_latent directly
http://codesearch.openstack.org/?q=set_latent&i=nope&files=&repos=

2)use config option 'latent_XXXX' in paste deploy config files.
http://codesearch.openstack.org/?q=latent_&i=nope&files=&repos=

More details, please refer to https://review.openstack.org/#/q/message:set_latent

Changed in zun:
assignee: nobody → feng.shengqin@zte.com.cn (feng-shengqin)
Changed in magnum:
assignee: nobody → feng.shengqin@zte.com.cn (feng-shengqin)
Rajat Sharma (tajar29)
Changed in octavia:
assignee: nobody → Rajat Sharma (tajar29)
Changed in oslo.middleware:
assignee: nobody → Rajat Sharma (tajar29)
Rajat Sharma (tajar29)
Changed in oslo.middleware:
assignee: Rajat Sharma (tajar29) → nobody
Revision history for this message
Michael Johnson (johnsom) wrote :

Octavia proposed patch here: https://review.openstack.org/#/c/489169

Changed in octavia:
importance: Undecided → Medium
status: New → In Progress
Changed in octavia:
status: In Progress → Fix Committed
Changed in magnum:
assignee: feng.shengqin@zte.com.cn (feng-shengqin) → nobody
Changed in zun:
assignee: feng.shengqin@zte.com.cn (feng-shengqin) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/494778

Changed in magnum:
assignee: nobody → ChangBo Guo(gcb) (glongwave)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zun (master)

Fix proposed to branch: master
Review: https://review.openstack.org/494780

Changed in zun:
assignee: nobody → ChangBo Guo(gcb) (glongwave)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zun (master)

Reviewed: https://review.openstack.org/494780
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=1c265af18209dfc773674abe21b0996f78245f27
Submitter: Jenkins
Branch: master

commit 1c265af18209dfc773674abe21b0996f78245f27
Author: ChangBo Guo(gcb) <email address hidden>
Date: Fri Aug 18 11:31:06 2017 +0800

    Remove deprecated usage of CORS.set_latent

    Method set_latent is deprecated in favor of method set_defaults in
    e9c3a23e845d8c53b266a3b2e4ca7fb0a5a0425a. We need remove the usage of
    method set_latent. We just use these config options in tests, it works
    well for unit tests without them, so it's safe to remove them.

    Closes-Bug: #1707151

    Change-Id: Ifb79f55b093415a5f2d6a018d6344d82b4a99d31

Changed in zun:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/494778
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=f46cb1fc3d8cfd85e74833380052aacfc716d3a4
Submitter: Jenkins
Branch: master

commit f46cb1fc3d8cfd85e74833380052aacfc716d3a4
Author: ChangBo Guo(gcb) <email address hidden>
Date: Fri Aug 18 11:16:02 2017 +0800

    Remove deprecated usage of CORS.set_latent

    Method set_latent is deprecated in favor of method set_defaults in
    e9c3a23e845d8c53b266a3b2e4ca7fb0a5a0425a. We need remove the usage of
    method set_latent. We just use these config options in tests, it works
    well for unit tests without them, so it's safe to remove them.

    Change-Id: I582c787395d6eef559d7914bea815440cc09c0e2
    Closes-Bug: #1707151

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
ChangBo Guo(gcb) (glongwave) wrote :

There is only one place to use set_latent

templates/glance-glare-paste.ini.j2
57# Accept = X-OpenStack-Request-ID
58# Expose = X-OpenStack-Request-ID
59latent_allow_headers = Content-MD5, Accept-Encoding, X-Auth-Token, X-Identity-Status, X-Roles, X-Service-Catalog, X-User-Id, X-Tenant-Id, X-OpenStack-Request-ID
60latent_expose_headers = X-Auth-Token, X-Subject-Token, X-Service-Token, X-OpenStack-Request-ID

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 5.0.0

This issue was fixed in the openstack/magnum 5.0.0 release.

no longer affects: openstack-ansible
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zun 1.0.0

This issue was fixed in the openstack/zun 1.0.0 release.

Revision history for this message
Ben Nemec (bnemec) wrote :
Changed in oslo.middleware:
status: New → Fix Released
Changed in octavia:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.