docker_volume_type should not be a required parameter

[Mark Goddard]

When creating a kubernetes cluster on baremetal & fedora, if the cluster template does not have a docker_volume_type defined, the following error is seen:

InvalidParameterValue: ERROR: The Parameter (docker_volume_type) was not provided.

My environment doesn't support cinder, and in fact the current bare metal driver doesn't support cinder, so I shouldn't need to care about this parameter.

Here's the command used to create the cluster:

magnum cluster-create --keypair controller --name k8s --node-count 1 --master-count 1 --cluster-template k8s-fedora-25

Here's the cluster template used:

+-----------------------+--------------------------------------+
| Property | Value |
+-----------------------+--------------------------------------+
| insecure_registry | - |
| labels | {} |
| updated_at | - |
| floating_ip_enabled | True |
| fixed_subnet | p3-internal |
| master_flavor_id | compute-A-magnum |
| uuid | a30e88d8-4da7-477f-af64-705cc036bbdb |
| no_proxy | - |
| https_proxy | - |
| tls_disabled | False |
| keypair_id | - |
| public | False |
| http_proxy | - |
| docker_volume_size | 3 |
| server_type | bm |
| external_network_id | ilab |
| cluster_distro | fedora |
| image_id | k8s-fedora-25 |
| volume_driver | - |
| registry_enabled | False |
| docker_storage_driver | devicemapper |
| apiserver_port | - |
| name | k8s-fedora-25 |
| created_at | 2017-07-03T11:09:34+00:00 |
| network_driver | flannel |
| fixed_network | p3-internal |
| coe | kubernetes |
| flavor_id | compute-A-magnum |
| master_lb_enabled | False |
| dns_nameserver | 8.8.8.8 |
+-----------------------+--------------------------------------+

I can work around this by adding the following section in magnum.conf:

[cinder]
default_docker_volume_type =

It appears that this was introduced with the changes to support bug 1678153.

[Spyros Trigazis (strigazi)]

So with:
[cinder]
default_docker_volume_type =

Works fine?

[Spyros Trigazis (strigazi)]

It should work. We can make the default volume type be "" and then you wouldn't have to set anything.

[Mark Goddard (mgoddard)]

> [cinder]
> default_docker_volume_type =
>
> Works fine?

Correct

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481144

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481144
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=ddde90e07c42d3699b005e912d49f97b03fd574d
Submitter: Jenkins
Branch: master

commit ddde90e07c42d3699b005e912d49f97b03fd574d
Author: Mark Goddard <email address hidden>
Date: Thu Jul 6 17:26:58 2017 +0100

    Add default for [cinder]default_docker_volume_type

    When creating a kubernetes cluster on baremetal & fedora, if the cluster
    template does not have a docker_volume_type defined, the following error
    is seen:

    InvalidParameterValue: ERROR: The Parameter (docker_volume_type) was not
    provided.

    Cinder isn't mandatory, and neither is the docker_volume_type cluster
    template parameter, so it shouldn't need to be set.

    This change adds a default value of an empty string for the option
    [cinder]default_docker_volume_type, which allows the cluster to be
    created.

    Change-Id: I4416e2826e4a14a11b93d55d342e4de9b3dc12d7
    Closes-Bug: #1702075

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/magnum 5.0.0 release.