allowing specifying labels on cluster-create

[Ricardo Rocha]

Several fields are being passed as labels (docker_volume_type is one example) which can only be set on the cluster template. For some of these users often want to override for their own clusters when using predefined and public cluster templates.

Blueprint https://blueprints.launchpad.net/magnum/+spec/flatten-attributes should solve this issue, but it requires a significant refactoring of the magnum code which makes the timeline for it to be done unclear.

In the meantime we should add this parameter explicitly on the cluster-create command so that users can already benefit from this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/473346
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=3d04ed4cbb63864f777b617ed48e2d167a0c6e20
Submitter: Jenkins
Branch: master

commit 3d04ed4cbb63864f777b617ed48e2d167a0c6e20
Author: Ricardo Rocha <email address hidden>
Date: Mon Jun 12 10:17:04 2017 +0000

    Allow labels on cluster create

    Add labels as an option during cluster create. If not given,
    the default is taken from the cluster template.

    Add labels in the Cluster object and use that instead
    of the one from ClusterTemplate.

    Update both magnum and magnum cli documentation to reflect the above changes.

    Partial-Bug: #1697651
    Implements: blueprint flatten-attributes
    Change-Id: I8990c78433dcbbca5bc4aa121678b02636346802

[Spyros Trigazis (strigazi)]

Bug in https://review.openstack.org/#/c/488439/

We should not set default=[]

https://review.openstack.org/#/c/488439/3/magnumclient/osc/v1/clusters.py@75
https://review.openstack.org/#/c/473343/15/magnumclient/v1/clusters_shell.py@109

Currently the client will always pass an empty list which then will be handled as an empty dict.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-magnumclient 2.8.0 release.