get_transport mis-use when messaging backends are separated

[Andy Smith]

With the ability to separate RPC and Notification messaging backends, the API should be uniform with respect to retrievel of associated transports:

get_rpc_transport
get_notifiation_transport

The current get_transport has the potential for mis-use based on configuration or an incorrect association to notifier.

See:
https://review.openstack.org/452793/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/454194
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=ec4d6639bc7556afaf439d261b716818b02a1605
Submitter: Jenkins
Branch: master

commit ec4d6639bc7556afaf439d261b716818b02a1605
Author: Andrew Smith <email address hidden>
Date: Thu Apr 6 09:47:34 2017 -0400

    Add get_rpc_transport call

    The get_rpc_transport wraps get_transport to unify the API in
    anticipation of comprehensive separation of RPC and Notification
    messaging backends.

    Related-Bug: 1680192
    Change-Id: Ic6af07b98ff43806c2af38a3ba129991f1e0ec86

[Ken Giusti (kgiusti)]

oslo.messaging must also issue a 'deprecated' warning (via debtcollector) when it detects an rpc transport being used for a notification client/server, and vice versa.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/501488

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501488
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=03b6f18f80b11e7067b94759c5da6a75f839bed7
Submitter: Jenkins
Branch: master

commit 03b6f18f80b11e7067b94759c5da6a75f839bed7
Author: Rajath Agasthya <email address hidden>
Date: Wed Sep 6 14:58:32 2017 -0700

    Warn when wrong transport instance is used

    Since RPC and notifications can have different backends, it is
    useful to warn users if they use a notification transport in RPC
    and vice versa. This patch introduces RPCTransport and
    NotificationTransport subclasses of Transport, so it's easier to
    add different behavior for them if need be.

    Related-Bug: #1680192
    Change-Id: Iab60544d69053c8e74c28a2d5c84665be749013f

[Ken Giusti (kgiusti)]

All the changes for this have landed.
The old get_transport() call has been marked deprecated for removal since Pike.