Make periodic monitoring tasks optional

[Spyros Trigazis]

In deployments without ceilometer, pulling all the clusters results on unnecessary load.

Additionally, docker-py and kubernetes clients have been proven buggy so far, overloading the magnum-conductor log woth tracebacks.

We need to make the pulling of COE data optional on the periodic task.

[Kirsten G. (oikiki)]

Hi Spyros,

I've looked through the codebase to understand monitoring tasks and where the data is being pulled. monitors.py has the abstract class pull_data() and then each type has it's own pull_data for example K8sMonitor.pull_data().

I am thinking that I should add an optional config param (to either magnum/conf rpc.py or cluster.py) that will be checked before pull_data() in periodic.py (line155) is executed? Is that on the right track? If so, should this be one param for all of the pull_data() functions (k8s/mesos/swarm) or should there be a way for the user to set preferences for each one separately?

Thank you!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/529098

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/529098
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=cf8468394027ffb1db420a72312b6a9f59b78381
Submitter: Zuul
Branch: master

commit cf8468394027ffb1db420a72312b6a9f59b78381
Author: Kirsten G <email address hidden>
Date: Tue Dec 19 07:57:55 2017 -0800

    Add send_cluster_metrics configuration parameter

    Added configuration parameter, send_cluster_metrics, to magnum.conf
    with default value of True. If set to True, periodic tasks will pull
    COE data and send to ceilometer. This parameter can be set to False to
    disable periodic collection of data to avoid unnecessary load from the
    cluster.

    Closes-Bug: #1668330
    Related-Bug: #1746510

    Change-Id: I9945293e7b2b52731f6e220d0925c1f6ad097caa

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/magnum 6.0.0 release.