"client" param not passed to AuthorizationFailure Exception

Bug #1666790 reported by yatin
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
yatin

Bug Description

AuthorizationFailure Exception requires "client" param to be passed
Reference: magnum/common/exception.py

class AuthorizationFailure(MagnumException):
    message = _("%(client)s connection failed. %(message)s")

Whenever we raise AuthorizationFailure Exception, we need to pass "client" param.

Currently exception without "client" param is raised at Following places:-

magnum/common/keystone.py
-------------------------

from magnum.common import exception
...
auth = ka_v3.Password(**auth_info)

        else:
            LOG.error(_LE('Keystone API connection failed: no password, '
                          'trust_id or token found.'))
            raise exception.AuthorizationFailure()
...
    @property
    def trustee_domain_id(self):
        if not self._trustee_domain_id:
            try:
                access = self.domain_admin_auth.get_access(
                    self.domain_admin_session
                )
            except kc_exception.Unauthorized:
                LOG.error(_LE("Keystone client authentication failed"))
                raise exception.AuthorizationFailure()

Error logs Reference: http://logs.openstack.org/38/414838/12/check/gate-functional-dsvm-magnum-swarm-ubuntu-xenial/d065c4e/logs/screen-magnum-cond.txt.gz#_2017-02-22_03_16_24_773

yatin (yatinkarel)
Changed in magnum:
assignee: nobody → yatin (yatinkarel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/436790

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/436790
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=44b83d3b142e84b14c5fda3ede76e6210a22b422
Submitter: Jenkins
Branch: master

commit 44b83d3b142e84b14c5fda3ede76e6210a22b422
Author: yatinkarel <email address hidden>
Date: Wed Feb 22 12:32:41 2017 +0530

    Pass 'client', 'message' param to AuthorizationFailure Exception

    Change-Id: Ia3f39a0362259429f4d2d995e94073a993ae48a7
    Closes-Bug: #1666790

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
Mark Goddard (mgoddard) wrote :

I'm seeing this in magnum 4.1.1.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/464187

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (stable/ocata)

Reviewed: https://review.openstack.org/464187
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=1a685113d8df479c56ad85aa001930f6b8f1e2dd
Submitter: Jenkins
Branch: stable/ocata

commit 1a685113d8df479c56ad85aa001930f6b8f1e2dd
Author: yatinkarel <email address hidden>
Date: Wed Feb 22 12:32:41 2017 +0530

    Pass 'client', 'message' param to AuthorizationFailure Exception

    Change-Id: Ia3f39a0362259429f4d2d995e94073a993ae48a7
    Closes-Bug: #1666790
    (cherry picked from commit 44b83d3b142e84b14c5fda3ede76e6210a22b422)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 4.1.2

This issue was fixed in the openstack/magnum 4.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 5.0.0

This issue was fixed in the openstack/magnum 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.