Docker should use systemd drop-in for proxy variables

Bug #1647815 reported by Kevin Lefevre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Kevin Lefevre

Bug Description

Docker should use systemd drop-in units for settings proxy configuration :

https://docs.docker.com/engine/admin/systemd/#/http-proxy

I already submitted a pacth for swarm : https://bugs.launchpad.net/magnum/+bug/1632698

This is the same patch for Kubernetes on CoreOS and Atomic template

Changed in magnum:
assignee: nobody → Kevin Lefevre (archifleks)
status: New → In Progress
Changed in magnum:
assignee: Kevin Lefevre (archifleks) → yatin (yatinkarel)
Changed in magnum:
assignee: yatin (yatinkarel) → Kevin Lefevre (archifleks)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/407516
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=8d7bc9c99eda792d46b8b57994fe5db36e37a830
Submitter: Jenkins
Branch: master

commit 8d7bc9c99eda792d46b8b57994fe5db36e37a830
Author: ArchiFleKs <email address hidden>
Date: Tue Dec 6 14:58:52 2016 +0100

    Make Docker proxy configuration consistent across template

    Closes-Bug: #1647815
    Related-Bug: #1632698
    Change-Id: Ic5e5cadd3d912f01072eff427a1095309c4f6e9b

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 4.0.0

This issue was fixed in the openstack/magnum 4.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to magnum (master)

Reviewed: https://review.openstack.org/457806
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=35dc923d66213edebf7db122dd929d79a8eb4cf7
Submitter: Jenkins
Branch: master

commit 35dc923d66213edebf7db122dd929d79a8eb4cf7
Author: Michael Tupitsyn <email address hidden>
Date: Mon Apr 17 15:39:45 2017 -0700

    Fix no_proxy evaluation for Swarm clusters

    At the moment, no_proxy variable is evaluated separately for docker
    daemon and for swarm-manager container running in docker. Evaluated
    value for swarm-manager is not getting into cloud-init script, because
    $NODE_PROXY token is getting replaced by Heat str_replace function.
    This commit is intended to unify NO_PROXY evaluation and also fix the
    issue with swarm-manager.

    Related-Bug: #1647815
    Related-Bug: #1632698
    Related-Bug: #1660562
    Change-Id: I336024265008b6cae308bf7b614476b71b81fa01

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to magnum (stable/pike)

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/497529

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to magnum (stable/pike)

Reviewed: https://review.openstack.org/497529
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=464186b7fa85905c2d27c798b3d05c15f292c064
Submitter: Jenkins
Branch: stable/pike

commit 464186b7fa85905c2d27c798b3d05c15f292c064
Author: Michael Tupitsyn <email address hidden>
Date: Mon Apr 17 15:39:45 2017 -0700

    Fix no_proxy evaluation for Swarm clusters

    At the moment, no_proxy variable is evaluated separately for docker
    daemon and for swarm-manager container running in docker. Evaluated
    value for swarm-manager is not getting into cloud-init script, because
    $NODE_PROXY token is getting replaced by Heat str_replace function.
    This commit is intended to unify NO_PROXY evaluation and also fix the
    issue with swarm-manager.

    Related-Bug: #1647815
    Related-Bug: #1632698
    Related-Bug: #1660562
    Change-Id: I336024265008b6cae308bf7b614476b71b81fa01
    (cherry picked from commit 35dc923d66213edebf7db122dd929d79a8eb4cf7)

tags: added: in-stable-pike
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.