Cleanup Magnum source code

Bug #1627663 reported by yatin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
In Progress
Undecided
yatin

Bug Description

Source code of magnum is changed/structured too much in Newton, some code updation/deletion is missed, which can be cleaned up.

1) Cleanup exception.py: pod, rc, container are removed so there exception's can be removed.
Earlier cleanup for exception was done with this patch also: https://review.openstack.org/#/c/320843/

2) k8s_manifest and its UT: since pod, rc and service are removed from magnum code, k8s_manifest which was used by by them can be removed.

3) yamlutils.py and its UT: yamlutils was added in beginning, since then it is not used, so should be removed.

4. safe_utils.py: it was used until it's use is removed in: https://review.openstack.org/#/c/320843/
, this can be removed now.

5) Translations for Pod/rc/container/svc

6) k8s fragments enable-etcd.sh is not used, etcd is enabled in master with enable-services-master.sh

7) Remove "provision_state" parameters(specific to ironic) from magnum source code these were originally copied from ironic: https://review.openstack.org/#/c/138280

Other code cleanup can also be tracked within this bug report only by updating bug description and submitting patches seperately for each cleanup.

yatin (yatinkarel)
Changed in magnum:
assignee: nobody → yatin (yatinkarel)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/376348

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/376356

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/376362

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/376365

yatin (yatinkarel)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/377415

yatin (yatinkarel)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by yatin (<email address hidden>) on branch: master
Review: https://review.openstack.org/377415
Reason: It would be automatically taken care by Zanata Bot.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/376356
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=bf1ace2c26b9a571dbed6f7d3bb9eb4bd35e1ec5
Submitter: Jenkins
Branch: master

commit bf1ace2c26b9a571dbed6f7d3bb9eb4bd35e1ec5
Author: yatin <email address hidden>
Date: Mon Sep 26 15:36:09 2016 +0530

    Remove k8s_manifest.py

    k8s_manifest.py was used by pod, rc and service objects.
    These objects have been removed recently, so k8s_manifest.py
    which was used by them is removed with this patch.

    Change-Id: I5f06f8a0d7b6cc4b7435ef3b645d7585772d70fb
    Implements: blueprint delete-container-endpoint
    Partial-Bug: #1627663

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/376348
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=4cc5a628d9059879d85806dc7636f20a243170ad
Submitter: Jenkins
Branch: master

commit 4cc5a628d9059879d85806dc7636f20a243170ad
Author: yatin <email address hidden>
Date: Mon Sep 26 15:26:16 2016 +0530

    Remove Exceptions for Container/Pod/Service

    k8s APIs pod, rcs, svc and container API have been
    removed. With this patch Exceptions specific to
    these API's are removed.

    Change-Id: I935672a9fe871c99a18e1f618151f01613c5ce04
    Implements: blueprint delete-container-endpoint
    Partial-Bug: #1627663

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/376362
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=78b4b091b2bc06e253f5716929e8d818a9201ac0
Submitter: Jenkins
Branch: master

commit 78b4b091b2bc06e253f5716929e8d818a9201ac0
Author: yatin <email address hidden>
Date: Mon Sep 26 15:41:02 2016 +0530

    Remove yamlutils.py

    yamlutils.py is never used, so it should be removed
    to keep code clean.

    Change-Id: I862eaca19170370248410775277a7af901643c41
    Partial-Bug: #1627663

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/376365
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=dc7b7af42a8fc3f7618dfbe6c26c0ae935fd2ede
Submitter: Jenkins
Branch: master

commit dc7b7af42a8fc3f7618dfbe6c26c0ae935fd2ede
Author: yatin <email address hidden>
Date: Mon Sep 26 15:46:17 2016 +0530

    Remove safe_utils.py

    safe_utils.py is not used after it's use is removed in
    below patch:
    https://review.openstack.org/#/c/320843/

    This module is removed with this patch.

    Change-Id: Ib75c60edc4bc8fb6e5b46c35e6975eb821b29797
    Partial-Bug: #1627663

yatin (yatinkarel)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/415609

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/415609
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=5902daf8ae49797fae06f713ff1fd24e41aa794d
Submitter: Jenkins
Branch: master

commit 5902daf8ae49797fae06f713ff1fd24e41aa794d
Author: yatin <email address hidden>
Date: Thu Dec 29 11:34:06 2016 +0530

    Remove provision_state parameters(specific to ironic)

    The provision_state parameter was copied from ironic
    with following patch:
    https://review.openstack.org/#/c/138280

    It should be removed as it's not required in magnum.

    Change-Id: Id9e08ee731ae79531c8e29fd47e4fa650b1c5dcc
    Partial-Bug: #1627663

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.