fix magnum manage templates

Bug #1612596 reported by Spyros Trigazis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
High
Hieu LE

Bug Description

cmd/template_manage doesn't read the configuration from magnum.conf properly.

to test that the configuration is not loaded properly do the following:
change the enabled_definitions in magnum.conf and do list-templates. The output of the command is wrong. These tests should catch it, and we also need to fix template_manage.

Changed in magnum:
importance: Undecided → High
Hieu LE (hieulq)
Changed in magnum:
assignee: nobody → Hieu LE (hieulq)
Revision history for this message
Spyros Trigazis (strigazi) wrote :

Please user cliff and openstack/osc-lib where possible.

The command must have the option --config-file and --config-dir or use the default magnum.conf. This functionality is provided but oslo_config.

NOTE:
if you get into the magnum-template-manage shell, issuing list-templates actually works, but issuing directly "magnum-template-manage list-templates" doesn't work properly.

Changed in magnum:
status: New → In Progress
Revision history for this message
Hieu LE (hieulq) wrote :

Hi Spyros, I prefer using cliff with default magnum.conf file.

Revision history for this message
Hieu LE (hieulq) wrote :

Seems that there are some problems with Gerrit, below are patch link:
https://review.openstack.org/#/c/353951/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/353951
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=99cfbcbc8bcdb69e75ebd39dc19273da6c64eae5
Submitter: Jenkins
Branch: master

commit 99cfbcbc8bcdb69e75ebd39dc19273da6c64eae5
Author: Hieu LE <email address hidden>
Date: Thu Aug 11 18:10:30 2016 +0700

    Make magnum manage_template read config file and increase coverage

    Currently magnum-manage-template command doesn't read config file
    properly. This patch make manage-template script read config file
    and display template list the right way.

    Add new unit tests for cmd/template_manage.py.
    Increase the coverage for cmd/template_manage.py from 0 to 100%.

    Change-Id: I3a4df33834201148f824ebe013c5a22aee3ec1f8
    Partial-Bug: #1511667
    Closes-Bug: #1612596

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.1.0

This issue was fixed in the openstack/magnum 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.