k8s heat templates are confusing master with minion

[Piotr Parczewski]

k8s master is the first instance being spawned by bay creation - however, it's configured with 'minion' user. This is highly confusing.

Steps to reproduce:

1. Use devstack with magnum.
2. Create bay with coe = kubernetes

[rajiv (rajiv-kumar)]

There are two possibilities for solution:

1) Change the user name from the minion to some generic name, not dependant on the role of the instance. Name can be something describing driver name or used base image. So choices might be
   a) kubernetes
   b) fedora/coreos

2) Change the user name of the instance hosting master, from the "minion" to "master" and keep minion user name as it is.

No. 2 option introduce little complexity into the code. For just user name, we have to add extra code and maintain it. Now it has to be decided whether it is worth implementing or not.

No. 1.b suffer from the same disadvantage of No 2.

No. 1.a is easy to implement and does not require addition of extra code, just name from "minion" to generic name(TBD) will be changed.

[Spyros Trigazis (strigazi)]

This choice was made when these templates were suppose to work with different distros [1].

We should the name change and left as it is the image. In our case will be fedora.

[1] https://github.com/larsks/heat-kubernetes/commit/747d06c8797ca6f14629683a3fb3376d8aae3782

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/351926

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/351926
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=83d154607e626ad09cee75521d6a3b51f48b2c6d
Submitter: Jenkins
Branch: master

commit 83d154607e626ad09cee75521d6a3b51f48b2c6d
Author: Drago Rosson <email address hidden>
Date: Fri Aug 5 20:39:42 2016 +0000

    Remove kube-user.yaml

    Since the fedora atomic already gets set up with the user "fedora",
    we can get rid of the "minion" user since it does not add any value
    and it is somewhat confusing logging into master nodes as "minion".

    Change-Id: I8c842d08780a786a1568f2d50219e580334ef487
    Closes-bug: #1608923

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/magnum 3.0.0 release.