Heat templates of different drivers contain duplicate code for network creation.

Bug #1606912 reported by rajiv
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Wishlist
Mathieu Velten

Bug Description

Heat templates has duplicate code for network setup in k8s coreos, fedora atomic and swarm drivers. A customized resource can be created for magnum, which can be reused for all the drivers.

rajiv (rajiv-kumar)
Changed in magnum:
assignee: nobody → rajiv (rajiv-kumar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/347858

Changed in magnum:
status: New → In Progress
hongbin (hongbin034)
Changed in magnum:
importance: Undecided → Wishlist
rajiv (rajiv-kumar)
summary: - Heat templates of different drivers contain duplicate code
+ Heat templates of different drivers contain duplicate code for network
+ creation.
description: updated
Changed in magnum:
assignee: rajiv (rajiv-kumar) → Spyros Trigazis (strigazi)
Changed in magnum:
assignee: Spyros Trigazis (strigazi) → Mathieu Velten (matmaul)
Changed in magnum:
assignee: Mathieu Velten (matmaul) → yatin (yatinkarel)
Changed in magnum:
assignee: yatin (yatinkarel) → Mathieu Velten (matmaul)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/347858
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=10e85ee6cefd5915b8b7eb7f210784cea323b4e2
Submitter: Jenkins
Branch: master

commit 10e85ee6cefd5915b8b7eb7f210784cea323b4e2
Author: Rajiv Kumar <email address hidden>
Date: Wed Jul 27 19:35:41 2016 +0530

    Consolidate heat network resources

    Currently for each driver has following code
      1) Create a fixed Network.
      2) Create a fixed subnet in the network created at step 1.
      3) Create a router
      4) Attach subnet(created at step2) to router(created at step 3)

    A new resource is created for above tasks in network.yaml file.
    New resource does the above tasks and output the fixed network ID
    and fixed subnet id, which is used by other parts of the heat
    template.

    Change-Id: Ib347ce5c54c6566300a43e05b277bf80351a2256
    Closes-Bug: #1606912

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 4.0.0

This issue was fixed in the openstack/magnum 4.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.