Remove unused code in CoreOS K8s bay driver

Bug #1606655 reported by Ton Ngo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Wishlist
Eli Qiao

Bug Description

Some of the files in the template/fragments are left over from the bay driver refactoring, because the previous directory had scripts for both Fedora and CoreOS distro. It would be good to check for those that are left over and not used with CoreOS, so they can be cleaned up.
For example, make-cert-client.sh has been copied into make-cert-client-coreos.yaml. Similarly for make-cert.sh

While we are cleaning up, we can also rename the remaining files with "-coreos" suffix since this is redundant, we are already in the coreos bay driver. For instance:

magnum/drivers/k8s_coreos_v1/templates/fragments/enable-kube-proxy-master-coreos.yaml

Ton Ngo (ton-i)
description: updated
Revision history for this message
Eli Qiao (taget-9) wrote :
Changed in magnum:
assignee: nobody → Eli Qiao (taget-9)
status: New → In Progress
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/346636
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=f081cf18e55ad85f87e94814a27788d6a825ed4e
Submitter: Jenkins
Branch: master

commit f081cf18e55ad85f87e94814a27788d6a825ed4e
Author: Eli Qiao <email address hidden>
Date: Mon Jul 25 15:52:13 2016 +0800

    k8s_coreos_driver: cleanup file naming

    Since we have seperate template files to different driver directory, we
    can cleanup -coreos suffix from template.

    1. Remove unused shell scripts.
    2. Remove kube-examples.yaml and kube-user.yaml which is never used.

    Closes-bug: #1606655
    Change-Id: I6ac93ad23e7ae30ad1eb9be1c79c2cf36af8db0c

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.