The WaitConditionHandle resource of swarm is repeated

Bug #1603999 reported by PanFengyun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
PanFengyun

Bug Description

The master_wait_handle and cloud_init_wait_handle are the same, the node_agent_wait_handle and node_cloud_init_wait_handle are the same. We just need only one,and there is no need to create two resources of OS::Heat::WaitConditionHandle. Heat will wait for all of the conditions to return, so one is enough.
To converge more with k8s templates, we should use master_wait_handle instead of cloud_init_wait_handle and use node_agent_wait_handle instead of node_cloud_init_wait_handle.

Changed in magnum:
assignee: nobody → PanFengyun (pan-feng-yun)
Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/342854
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=1b3ab819ef102a1c634f787f579ad871ef31461d
Submitter: Jenkins
Branch: master

commit 1b3ab819ef102a1c634f787f579ad871ef31461d
Author: PanFengyun <email address hidden>
Date: Mon Jul 18 21:30:21 2016 +0800

    Remove repeated WaitConditionHandle resource

    The master_wait_handle and cloud_init_wait_handle are the same,
    the node_agent_wait_handle and node_cloud_init_wait_handle are
    the same. We just need only one. To converge more with k8s
    templates, we should use master_wait_handle instead of
    cloud_init_wait_handle and use node_agent_wait_handle instead of
    node_cloud_init_wait_handle.

    Change-Id: Icc07ef8407c05ef37a35c7f418c11c562572cab5
    Closes-Bug: #1603999

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.