Microversion handling should be based on service type, not service name

Bug #1590593 reported by Everett Toews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
rajiv

Bug Description

Magnum is using the service name for its microversion handling [1][2]. The microversion guideline [3] states that the service *type* should be used.

According to the devstack script [4] the service type is "container-infra". If that's correct, that's what service_string at [1] should be set to.

[1] http://git.openstack.org/cgit/openstack/magnum/tree/magnum/api/controllers/base.py#n65
[2] http://git.openstack.org/cgit/openstack/magnum/tree/magnum/api/controllers/base.py#n106
[3] http://specs.openstack.org/openstack/api-wg/guidelines/microversion_specification.html
[4] http://git.openstack.org/cgit/openstack/magnum/tree/devstack/lib/magnum#n118

rajiv (rajiv-kumar)
Changed in magnum:
assignee: nobody → rajiv (rajiv-kumar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334328

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/334328
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=899fbdd2f199cbc74aac9908265a8ff990431e24
Submitter: Jenkins
Branch: master

commit 899fbdd2f199cbc74aac9908265a8ff990431e24
Author: Rajiv Kumar <email address hidden>
Date: Mon Jun 27 13:15:15 2016 +0530

    Change service name from "magnum" to "container-infra"

    As per microversion guideline, the service type should be used for
    microversion handling but service name(magnum) is being used. As per
    devstack scripts type of the services has been changed to
    "container-infra".

    Change-Id: Icd52f75e76ef4126b7c269863a51b8aea459f597
    Closes-Bug: #1590593

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.