Add more fields to unset_exception list

Bug #1579236 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Yosef Hoffman

Bug Description

In baymodel (https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/baymodel.py), we have an unset exception list:

            baymodel.unset_fields_except(['uuid', 'name', 'image_id',
                                          'apiserver_port', 'coe'])

We need to add more attribute to the list so that the new "--fields" option [1] will work better. In particular, I think the fields below should be added:

uuid
name
coe
image_id
flavor_id
master_flavor_id
keypair_id
network_driver
apiserver_port
docker_volume_size
cluster_distro
volume_driver
registry_enabled
tls_disabled
public
server_type

[1] https://review.openstack.org/#/c/286950/

hongbin (hongbin034)
tags: added: low-hanging-fruid
tags: added: low-hanging-fruit
removed: low-hanging-fruid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314799

Changed in magnum:
assignee: nobody → Yosef Hoffman (yh128t)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/314799
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=66cbd8c821bda168bc07ab3aaa1fe4d7717fc7ff
Submitter: Jenkins
Branch: master

commit 66cbd8c821bda168bc07ab3aaa1fe4d7717fc7ff
Author: Yosef Hoffman <email address hidden>
Date: Tue May 10 18:38:42 2016 -0400

    Always expand Baymodel fields

    In baymodel (https://github.com/openstack/magnum/blob/master/magnum/
    api/controllers/v1/baymodel.py), we have an unset exception list:

                baymodel.unset_fields_except(['uuid', 'name', 'image_id',
                                              'apiserver_port', 'coe'])

    In order for the new "--fields" option [1] to work better, this patch will
    remove the expand option so that all fields are included by default.

    [1] https://review.openstack.org/#/c/286950/

    Change-Id: I1adffca9a7c6e013bed38530036dfc0aed918fdc
    Closes-Bug: #1579236

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.