private key will be checked every time when in remote_exec

[Eli Qiao]

http://logs.openstack.org/14/286414/3/check/gate-functional-dsvm-magnum-k8s/4458771/console.html

Seen from functional test log.

2016-03-02 16:50:23.273 | 2016-03-02 16:50:23.280 | + remote_exec minion 'sudo journalctl -u docker-storage-setup --no-pager' docker-storage-setup.log
2016-03-02 16:50:23.274 | 2016-03-02 16:50:23.282 | + local priv_key
2016-03-02 16:50:23.276 | 2016-03-02 16:50:23.283 | + echo 'If private key is specified, save to temp and use that; else, use default'
2016-03-02 16:50:23.277 | 2016-03-02 16:50:23.284 | + [[ default == \d\e\f\a\u\l\t ]]
2016-03-02 16:50:23.281 | 2016-03-02 16:50:23.287 | + priv_key='~/.ssh/id_rsa'
2016-03-02 16:50:23.283 | 2016-03-02 16:50:23.290 | + local ssh_user=minion
2016-03-02 16:50:23.308 | 2016-03-02 16:50:23.292 | + local 'cmd=sudo journalctl -u docker-storage-setup --no-pager'
2016-03-02 16:50:23.308 | 2016-03-02 16:50:23.294 | + local logfile=/opt/stack/logs/bay-nodes/node-test_replication_controller_apis-172.24.5.6/docker-storage-setup.log

We get priv_key in remote_exec, so every time we call remote_exec, we need to compute it again, this can be move out.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289180

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289180
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=30a436cf4939872e2568306da35686c9c628491e
Submitter: Jenkins
Branch: master

commit 30a436cf4939872e2568306da35686c9c628491e
Author: Eli Qiao <email address hidden>
Date: Thu Mar 3 09:58:22 2016 +0800

    Functional: Set private key outside of remote_exec

    We get priv_key in remote_exec, so every time we call remote_exec, we
    need to compute it again, this can be move out.

    Closes-Bug: #1552502
    Change-Id: Id44cd5e98f070985feef2583162bd21bca44baf2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/magnum 2.0.0 release.