A lot of H404/405 violations

Bug #1521899 reported by Ken'ichi Ohmichi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum UI
Fix Released
Undecided
Shu Muto
python-neutronclient
Fix Released
Undecided
Akihiro Motoki
python-novaclient
Won't Fix
Undecided
Ghanshyam Mann
tempest
Fix Released
Undecided
Ken'ichi Ohmichi

Bug Description

python-novaclient has its long history, and when adding H404/405 rule on common hacking, we have disabled on these rules.
After that, the violation code continue increasing.
We need to fix the code soon for avoiding more violations.

Changed in python-novaclient:
assignee: nobody → Ken'ichi Ohmichi (oomichi)
Revision history for this message
Ken'ichi Ohmichi (oomichi) wrote :
Changed in tempest:
status: New → Fix Committed
assignee: nobody → Ken'ichi Ohmichi (oomichi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/252325

Changed in python-novaclient:
assignee: Ken'ichi Ohmichi (oomichi) → Ghanshyam Mann (ghanshyammann)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/252348

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/252363

Shu Muto (shu-mutou)
Changed in python-neutronclient:
assignee: nobody → Shu Muto (shu-mutou)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/252802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/252325
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=aa73df2649496f049118cfa7dae74a759edf9dd9
Submitter: Jenkins
Branch: master

commit aa73df2649496f049118cfa7dae74a759edf9dd9
Author: Ghanshyam <email address hidden>
Date: Wed Dec 2 19:36:45 2015 +0900

    Fix H404/405 violations in client.py,base.py,api_version.py

    There is a lot of H404/405 violations in novaclient, and it is better
    to fix those to have a better doc string for class/methods.

    This patch fixes these violations for below files-
    -api_versions.py
    -base.py
    -client.py

    As there are lot of violations and cannot be fixed in single patches,
    So separating those in multiple patches for easy review.

    Change-Id: I30a714fc3b0b317f7ffa4a99fbb224b4d5f5477b
    Partial-Bug: #1521899

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/254070

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/254134

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/252363
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=573bdaa290d87dfbf8d517395e44fd9737fdfb18
Submitter: Jenkins
Branch: master

commit 573bdaa290d87dfbf8d517395e44fd9737fdfb18
Author: Ghanshyam <email address hidden>
Date: Mon Dec 7 14:17:56 2015 +0900

    Fix H404/405 violations in novaclient/tests/*

    There is a lot of H404/405 violations in novaclient, and it is better
    to fix those to have a better doc string for class/methods.

    This patch fixes these violations for files under novaclient/tests/
    folder.

    As there are lot of violations and cannot be fixed in single patches,
    So separating those in multiple patches for easy review.

    Partial-Bug: #1521899
    Change-Id: I6e712ece14c745013bfba0bee9d77e7875dd2263

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/254070
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=a37c4328a16a209803244e212fc99a74fad7ca4e
Submitter: Jenkins
Branch: master

commit a37c4328a16a209803244e212fc99a74fad7ca4e
Author: Ghanshyam <email address hidden>
Date: Mon Dec 7 17:35:19 2015 +0900

    Fix H404/405 violations in novaclient/v2/[a-f]

    There is a lot of H404/405 violations in novaclient, and it is better
    to fix those to have a better doc string for class/methods.

    This patch fixes these violations for [a-f] files under novaclient/v2
    folder.

    As there are lot of violations and cannot be fixed in single patches,
    So separating those in multiple patches for easy review.

    Change-Id: Ibe5afef349d1be6d70903e06bee402ca30738ea1
    Partial-Bug: #1521899

Changed in python-neutronclient:
assignee: Shu Muto (shu-mutou) → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/252802
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=ec4e4827317f5d9e2b5e4bc7f0774664c098da70
Submitter: Jenkins
Branch: master

commit ec4e4827317f5d9e2b5e4bc7f0774664c098da70
Author: shu-mutou <email address hidden>
Date: Thu Dec 3 15:40:14 2015 +0900

    Fix H405 violations

    There are a lot of H405 violation codes.
    We need to fix the code for avoiding more violations.

    Change-Id: Iaa83626b81a3d8369b16e2b4f394e2bc4628998a
    Closes-Bug: #1521899

Changed in python-neutronclient:
status: In Progress → Fix Released
Shu Muto (shu-mutou)
Changed in magnum-ui:
status: New → In Progress
assignee: nobody → Shu Muto (shu-mutou)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/263100

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum-ui (master)

Reviewed: https://review.openstack.org/263100
Committed: https://git.openstack.org/cgit/openstack/magnum-ui/commit/?id=50d44ae0d545ba2d1151a731bb3079b7510108ae
Submitter: Jenkins
Branch: master

commit 50d44ae0d545ba2d1151a731bb3079b7510108ae
Author: shu-mutou <email address hidden>
Date: Mon Jan 4 12:12:39 2016 +0900

    Fix H405 violations

    There are a lot of H405 violation codes.
    We need to fix the code for avoiding more violations.

    Change-Id: I0db7b2276126f60768dde0cdf6ebd8681029ec10
    Closes-Bug: #1521899

Changed in magnum-ui:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-neutronclient 4.0.0

This issue was fixed in the openstack/python-neutronclient 4.0.0 release.

Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 4.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-novaclient (master)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/252348

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/254134

Changed in tempest:
status: Fix Committed → Fix Released
Revision history for this message
Stephen Finucane (stephenfinucane) wrote :

I looked into doing this and it's a *lot* of work, for something of rather limited value. I've marked the novaclient bug as wontfix since it seems unlikely anyone will be working on this going forward.

Changed in python-novaclient:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.