DEFAULT_DOCKER_TIMEOUT =10 is too short

Bug #1519714 reported by Eli Qiao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Committed
Undecided
Eli Qiao

Bug Description

In Magnum code, we hard code it as DEFAULT_DOCKER_TIMEOUT = 10
This bring troubles in some bad networking environment (or bad performance swarm master)
At least it doesn't work on our gate.

Here is the test patch on gate https://review.openstack.org/249522 , I set it as 180 to make sure
the failure it due to time_out parameter passed to docker client, but we need to chose a suitble one

I check docker client's default value,

DEFAULT_TIMEOUT_SECONDS = 60,
suggest we set DEFAULT_DOCKER_TIMEOUT
as long as our rpc time_out.

Eli Qiao (taget-9)
Changed in magnum:
assignee: nobody → Eli Qiao (taget-9)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249682

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/250573

Changed in magnum:
assignee: Eli Qiao (taget-9) → Hua Wang (humble00)
Changed in magnum:
assignee: Hua Wang (humble00) → Eli Qiao (taget-9)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by Eli Qiao (<email address hidden>) on branch: master
Review: https://review.openstack.org/249682
Reason: will be fixed by https://review.openstack.org/250573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/250573
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=292a195242abb02f62642987b451096795cc0ba0
Submitter: Jenkins
Branch: master

commit 292a195242abb02f62642987b451096795cc0ba0
Author: Hua Wang <email address hidden>
Date: Fri Nov 27 09:43:31 2015 +0800

    Remove hardcoded default docker client setting

    This patch removes Hardcoded docker client settings and move them to configure
    setting. Changes default value of DEFAULT_DOCKER_TIMEOUT from 10 to 60.

    DEFAULT_DOCKER_TIMEOUT = 10 is too short, it brings troubles in some bad
    networking environment (or bad performance swarm master), and this won't work
    on gate.

    The docker-py client's default value: DEFAULT_TIMEOUT_SECONDS = 60,
    Suggest we set DEFAULT_DOCKER_TIMEOUT = 60, as long as our rpc time_out.

    There is a circle reference between magnum/common/docker_utils.py and
    magnum/conductor/handlers/common/docker_client.py, so I merge them.

    Co-Authored-By: Eli Qiao <email address hidden>

    Change-Id: I6046376cbf5eec6b0102956fd4e4f38b958dd80c
    Closes-Bug: #1519714

Changed in magnum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 2.0.0

This issue was fixed in the openstack/magnum 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.