Style of Heat template outputs are not consistent

Bug #1514252 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
hongbin

Bug Description

We'd better to make the outputs of heat template consistent. In particular, each template should have these five output keys:

* api_address
* XXX_master(s)
* XXX_master(s)_external
* kube_minions
* kube_minions_external

hongbin (hongbin034)
Changed in magnum:
assignee: nobody → hongbin (hongbin034)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/242886

Changed in magnum:
status: New → In Progress
Revision history for this message
Guangya Liu (Jay Lau) (jay-lau-513) wrote :

Why did each template need the following two?
* kube_minions
* kube_minions_external

Those should belong to kubernetes only, comments?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/242886
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=1b928008bda2216a219c51e529a099d589fffbbb
Submitter: Jenkins
Branch: master

commit 1b928008bda2216a219c51e529a099d589fffbbb
Author: Hongbin Lu <email address hidden>
Date: Sun Nov 8 18:24:26 2015 -0500

    Unify common output keys across Heat templates

    After this commit, all Heat templates have five common outputs:
    * api_address: API endpoint of specific COE.
    * kube_masters/swarm_master/mesos_master: Public IP address(es) of
      master node(s).
    * kube_masters_private/swarm_master_private/mesos_master_private:
      Private IP address(es) of master node(s).
    * kube_minions/swarm_nodes/mesos_slaves: List of public IP addresses
      of worker nodes.
    * kube_minions_private/swarm_nodes_private/mesos_slaves_private:
      List of private IP addresses of worker nodes.

    Change-Id: Ie44136dafa326db598a5f17978d89adce8e69801
    Closes-Bug: #1514252

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.