Magnum

Use AssertIsNone instead of assertEqual(None, ***)

Bug #1510006 reported by Bertrand Lallau
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Bertrand Lallau
Fuel for OpenStack
Confirmed
Low
Fuel Sustaining
Fuel for OpenStack 10.0
Mitaka
Won't Fix
Low
Fuel Sustaining
Fuel for OpenStack 9.0
Magnum
Fix Released
Undecided
Bertrand Lallau
Magnum mitaka-1
Murano
Fix Released
Low
Lin Yang
Murano mitaka-1 "m1"
congress
Fix Released
Undecided
Lin Yang
congress mitaka-2 "mitaka-2"
python-novaclient
Fix Released
Undecided
Takashi Natsume

Bug Description

Use assertIsNone instead of assertEqual(None, ***)

Instead of using assertEqual(None, ***), developers should
use assertIsNone(***).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239418

Revision history for this message
Cedric Brandily (cbrandily) wrote :

It seems this bug duplicates https://bugs.launchpad.net/neutron/+bug/1503055

OpenStack Infra (hudson-openstack)
Changed in designate:
assignee: nobody → Bertrand Lallau (bertrand-lallau)
status: New → In Progress
Peiyu Lin (mathspanda)
Changed in magnum:
assignee: nobody → Peiyu Lin (mathspanda)
lvdongbing (dbcocle)
Changed in heat:
assignee: nobody → lvdongbing (dbcocle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239611

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/239466
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=00b396b500529b138985c3cc12408aa262fe758a
Submitter: Jenkins
Branch: master

commit 00b396b500529b138985c3cc12408aa262fe758a
Author: Bertrand Lallau <email address hidden>
Date: Mon Oct 26 16:30:48 2015 +0100

    Use assertIsNone instead of assertEqual(None, ***)

    Instead of using assertEqual(None, ***), developers should
    use assertIsNone(***).

    Change-Id: I7be8259361130d28b6ada9f9db649a625f2cf64a
    Related-Bug: #1510006

OpenStack Infra (hudson-openstack)
Changed in magnum:
assignee: Peiyu Lin (mathspanda) → Bertrand Lallau (bertrand-lallau)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by LinPeiyu (<email address hidden>) on branch: master
Review: https://review.openstack.org/239611
Reason: https://review.openstack.org/#/c/239351/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/239351
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=e97f70788c951b405dd6b24b2dcac769f868a886
Submitter: Jenkins
Branch: master

commit e97f70788c951b405dd6b24b2dcac769f868a886
Author: Bertrand Lallau <email address hidden>
Date: Mon Oct 26 08:05:14 2015 +0100

    Use assertIsNone instead of assertEqual(None, ***)

    Instead of using assertEqual(None, ***), developers should
    use assertIsNone(***) to have more clear messages in case of failure.

    Closes-Bug: #1510006
    Change-Id: Ib3d09ed651877569a9b940da97662489885f18e9

Changed in magnum:
status: In Progress → Fix Committed
Lin Yang (lin-a-yang)
Changed in murano:
assignee: nobody → Lin Yang (lin-a-yang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/240473

Lin Yang (lin-a-yang)
Changed in murano:
status: New → In Progress
Victor Ryzhenkin (vryzhenkin)
Changed in murano:
importance: Undecided → Medium
milestone: none → mitaka-1
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano (master)

Reviewed: https://review.openstack.org/240473
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=d483f70f5526a8b959ede953fb1fce63a6c188e0
Submitter: Jenkins
Branch: master

commit d483f70f5526a8b959ede953fb1fce63a6c188e0
Author: Lin Yang <email address hidden>
Date: Fri Oct 30 16:11:38 2015 +0800

    Use assertIsNone instead of assertEqual(None, ***)

    Instead of using assertEqual(None, ***), developers should
    use assertIsNone(***).

    Change-Id: I49d8e0387a68a545c72a50e4b3aab423479d65ca
    Related-Bug: #1510006

Revision history for this message
Lin Yang (lin-a-yang) wrote :

This bug in Murano has been fixed by https://review.openstack.org/#/c/240473/.

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (master)

Change abandoned by Bertrand Lallau (<email address hidden>) on branch: master
Review: https://review.openstack.org/239418

Lin Yang (lin-a-yang)
Changed in congress:
assignee: nobody → Lin Yang (lin-a-yang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to congress (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/241870

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to congress (master)

Reviewed: https://review.openstack.org/241870
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=2775aa30be9a037aa4c0dfcb31bf4026ce7a4402
Submitter: Jenkins
Branch: master

commit 2775aa30be9a037aa4c0dfcb31bf4026ce7a4402
Author: Lin Yang <email address hidden>
Date: Thu Nov 5 12:51:57 2015 +0800

    Use assertIsNone instead of assertEqual(None, ***)

    Instead of using assertEqual(None, ***), developers should
    use assertIsNone(***).

    Change-Id: Id0861258ae9dda119db3e7b88990ebbf646e42b8
    Related-Bug: #1510006

Revision history for this message
Lin Yang (lin-a-yang) wrote :

The bug in congress has been fixed on patch 241870.

Changed in congress:
status: New → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
Kirill Zaitsev (kzaitsev)
Changed in murano:
status: Fix Committed → Fix Released
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → mitaka-2
status: Fix Committed → Fix Released
Takashi Natsume (natsume-takashi)
Changed in python-novaclient:
assignee: nobody → Takashi NATSUME (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/283454

Changed in python-novaclient:
status: New → In Progress
Béla Vancsics (vancsics)
Changed in fuel:
assignee: nobody → Béla Vancsics (vancsics)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/284111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/283454
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=f55e426dd4bd2373a00b0299e1aef8394bf9361c
Submitter: Jenkins
Branch: master

commit f55e426dd4bd2373a00b0299e1aef8394bf9361c
Author: Takashi NATSUME <email address hidden>
Date: Tue Feb 23 17:47:59 2016 +0900

    Use assertIsNone instead of assertEqual(None, ***)

    Instead of using assertEqual(None, ***), developers should
    use assertIsNone(***).

    Change-Id: I55e9161a4df9197546603385228ea85528de43a7
    Closes-Bug: #1510006

Changed in python-novaclient:
status: In Progress → Fix Released
Dmitry Klenov (dklenov)
Changed in fuel:
milestone: none → 9.0
importance: Undecided → Low
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-novaclient 3.3.0

This issue was fixed in the openstack/python-novaclient 3.3.0 release.

Dmitry Pyzhov (dpyzhov)
tags: added: area-python tech-debt
Angus Salkeld (asalkeld)
Changed in heat:
status: New → Confirmed
Graham Hayes (grahamhayes)
Changed in designate:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
Kiall Mac Innes (kiall) wrote :

Designate fixed in https://review.openstack.org/#/c/236869/

Béla Vancsics (vancsics)
Changed in fuel:
assignee: Béla Vancsics (vancsics) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/284111
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Oleksiy Molchanov (omolchanov)
Changed in fuel:
status: In Progress → Confirmed
assignee: nobody → Fuel Python Team (fuel-python)
Maksim Malchuk (mmalchuk)
no longer affects: fuel/newton
Thomas Herve (therve)
no longer affects: heat
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.