Heat Template Indentation

Bug #1504685 reported by Daneyon Hansen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Zachary Sais

Bug Description

Heat templates contain improper indentation. For example:

https://github.com/openstack/magnum/blob/master/magnum/templates/heat-kubernetes/fragments/enable-services-master.sh

All templates should be reviewed for indentation and updated accordingly.

Tags: tech-debt
Revision history for this message
Daneyon Hansen (danehans) wrote :

Quoting should be addressed also.

Revision history for this message
Daneyon Hansen (danehans) wrote :
Lin Yang (lin-a-yang)
Changed in magnum:
assignee: nobody → Lin Yang (lin-a-yang)
Lin Yang (lin-a-yang)
Changed in magnum:
assignee: Lin Yang (lin-a-yang) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/236291

Changed in magnum:
assignee: nobody → Zachary Sais (zsais)
status: New → In Progress
Revision history for this message
Daneyon Hansen (danehans) wrote :

From Tom Cammann:

For vxlan conditional in magnum/templates/docker-swarm/fragments/write-network-config.sh

If jq is available use it instead to create/append json.
   jq -n --arg cidr "$FLANNEL_NETWORK_CIDR" \
       --arg len "$FLANNEL_NETWORK_SUBNETLEN" \
       '{"Network": $cidr, "Subnetlen": $len}' > $FLANNEL_JSON
   if [ "$use_vxlan" = 1 ]; then
        jq '. + {"Backend": {"Type": "vxlan"}}' < $FLANNEL_JSON
   fi

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/236291
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=485d9a90189b8608a858eb2e85fbe0dda24bc775
Submitter: Jenkins
Branch: master

commit 485d9a90189b8608a858eb2e85fbe0dda24bc775
Author: Zachary Sais <email address hidden>
Date: Sat Oct 17 16:52:19 2015 -0500

    Cleanup template formatting

    This patch is meant to cleanup indentations in the templates, as
    well some other house keeping fixes.

    Closes-Bug: #1504685
    Change-Id: I43f6cca8f449dea2db4de6a5308bfa5e4551838e

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.