Incorporate comments on review ID #202873

Bug #1500850 reported by Madhuri Kumari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Medium
yatin

Bug Description

Hongbin, Ton and Egor gave some useful comments on review ID #202873 on patchset #21.

As this pacth is necessary for this Liberty release, we can let this patch go.
I have tested the patch with local_cert_manager and it works well.

Tags: tech-debt
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
Changed in magnum:
assignee: nobody → Madhuri Kumari (madhuri-rai07)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337512

Changed in magnum:
assignee: Madhuri Kumari (madhuri-rai07) → yatin (yatinkarel)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/337512
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=2f2971ba625776439634dfae32edef606da6d745
Submitter: Jenkins
Branch: master

commit 2f2971ba625776439634dfae32edef606da6d745
Author: yatinkarel <email address hidden>
Date: Tue Jul 5 13:12:29 2016 +0530

    Move Initialization of variables inside if/else

    Initialization of variables: KUBE_PROTOCOL and KUBE_CONFIG is
    done inside if/else for better readability and maintainability.

    Change-Id: I37dfe57cc1328f1531233d11667a020bb3e0de5b
    Partial-Bug: #1500850

yuanying (yuanying)
Changed in magnum:
status: In Progress → Fix Committed
Changed in magnum:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.