Missing input validation on baymodel type value

Bug #1497134 reported by wangqun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Low
wangqun

Bug Description

$ magnum baymodel-create --name swarmbaymodel \
> --image-id fedora-21-atomic-3 \
> --keypair-id testkey \
> --external-network-id public \
> --dns-nameserver 8.8.8.8 \
> --flavor-id m1.small \
> --coe sw
+---------------------+--------------------------------------+
| Property | Value |
+---------------------+--------------------------------------+
| fixed_network | None |
| apiserver_port | None |
| docker_volume_size | None |
| image_id | fedora-21-atomic-3 |
| no_proxy | None |
| external_network_id | public |
| created_at | 2015-09-18T07:10:38+00:00 |
| http_proxy | None |
| updated_at | None |
| cluster_distro | fedora-atomic |
| name | swarmbaymodel |
| ssh_authorized_key | None |
| https_proxy | None |
| registry_enabled | False |
| coe | sw |
| keypair_id | testkey |
| master_flavor_id | None |
| flavor_id | m1.small |
| dns_nameserver | 8.8.8.8 |
| uuid | 591f6ac0-1118-4a46-9c1b-249b87a34ce9 |
+---------------------+--------------------------------------+
 coe is wrong one, we need to refuse to create it.

wangqun (bjwqun)
Changed in magnum:
assignee: nobody → wangqun (bjwqun)
Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/228294
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=618f019f4d471bb2e05bfe813d8551cb32a325c6
Submitter: Jenkins
Branch: master

commit 618f019f4d471bb2e05bfe813d8551cb32a325c6
Author: Hongbin Lu <email address hidden>
Date: Mon Sep 28 00:00:17 2015 -0400

    Introduce BayType that declares valid COEs

    Restrict COE field to be one of 'kubernetes', 'swarm' and 'mesos'

    Change-Id: I8967b1cd826c8c22fa5c1d847776e5e0dd65c629
    Closes-Bug: #1497134

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
summary: - Using unsupport coe can create the bay model
+ Missing input validation on baymodel type value
Changed in magnum:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by Adrian Otto (<email address hidden>) on branch: master
Review: https://review.openstack.org/227128
Reason: @wangqun: Thanks so much for choosing magnum to make your first OpenStack contribution. I deeply appreciate your work,and hope that you continue to help us advance the project with work like this. In this case, we merged another fix for the bug:

https://review.openstack.org/228294

I'm marking this review as abandoned, in accordance with your previous comments. If you feel this matter should be revisited by Magnum's review team, you are welcome to un-abandon this change and restart the discussion.

Thanks,

Adrian Otto

Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.