improve port option validation

Bug #1488861 reported by lei zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
lei zhang

Bug Description

Option port only has a default value, so i think it will have some errors
when setting port outside the range of 1-65535

eg:
    cfg.IntOpt('port',
            default=9511,
            help='The port for the Magnum API server.')

According to http://docs.openstack.org/developer/oslo.config/cfg.html
oslo.config can use portType to support the ability to set valid range
on port option values

lei zhang (zhang-lei)
Changed in magnum:
assignee: nobody → lei zhang (zhang-lei)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217064

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/217064
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=d14382d997e7aa9c7d1dc891112ba252a1208a83
Submitter: Jenkins
Branch: master

commit d14382d997e7aa9c7d1dc891112ba252a1208a83
Author: lei-zhang-99cloud <zhang.lei@99cloud.net>
Date: Wed Aug 26 17:48:17 2015 +0800

    Add port type on port option

    According to http://docs.openstack.org/developer/oslo.config/cfg.html
    oslo.config can use portType to support the ability to set valid range
    on port option values

    Closes-Bug: #1488861

    Change-Id: Ic4310532f4155ade1706f0bca8df9466665aea97

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.