write a test case for swagger.deserialize

Bug #1460236 reported by Steven Dake
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
High
Madhuri Kumari

Bug Description

The test cases for swagger.deserialize should deserialize all of the expected V1beta3 JSON blobs. It is important that the correct JSON data is passed into the deserialize function. Contact madhuri on IRC to determine how to gather the JSON blob information. It is important that the resulting deserialized object is verified to match the JSON blob contents for each member of the object.

The goal of these test cases is to verify deserialize and the models work for the following objects and their child objects:

json_WatchEvent
V1beta3_ServiceList
V1beta3_SecretList
V1beta3_ResourceQuotaList
V1beta3_ReplicationControllerList
V1beta3_PodList
V1beta3_PersistentVolume
V1beta3_PersistentVolumeList
V1beta3_PersistentVolumeClaimList
V1beta3_Node
V1beta3_NodeList
V1beta3_Namespace
V1beta3_Service
V1beta3_ServiceList
V1beta3_Secret
V1beta3_SecretList
V1beta3_ResourceQuota
V1beta3_ResourceQuotaList
V1beta3_ReplicationController
V1beta3_ReplicationControllerList
V1beta3_PodLogOptions
V1beta3_Pod
V1beta3_PodList
V1beta3_PersistentVolumeClaim
V1beta3_PersistentVolumeClaimList
V1beta3_LimitRange
V1beta3_LimitRangeList
V1beta3_Event
V1beta3_EventList
V1beta3_Endpoints
V1beta3_EndpointsList
V1beta3_NamespaceList
V1beta3_LimitRangeList
V1beta3_EventList
V1beta3_EndpointsList

Each of these objects should be a separate test case. This would dramatically improve coverage and ensure when we do swagger codegen updates of our library we get expected results. This will be helpful for TLS support as well.

Steven Dake (sdake)
Changed in magnum:
status: New → Confirmed
importance: Undecided → High
Changed in magnum:
assignee: nobody → Madhuri Kumari (madhuri-rai07)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/189637

Changed in magnum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/190444

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/189637
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=789cf0ad2b8b05b94c942c8b406b569e409b0c82
Submitter: Jenkins
Branch: master

commit 789cf0ad2b8b05b94c942c8b406b569e409b0c82
Author: Madhuri Kumari <email address hidden>
Date: Tue Jun 9 19:14:16 2015 +0900

    Refactor magnum functional test to add Kubernetes API test

    To test Kubernetes API, we need bay created and as already in
    magnum functional test, we were creating bay. So this patch
    refactors the code to seperate methods for each operation. So
    that it can be used at other places.

    Change-Id: I64d1b13cdc7c86a007b200bf2e2547216a66eefc
    Partial-bug: #1460236

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-2
status: Fix Committed → Fix Released
Adrian Otto (aotto)
Changed in magnum:
milestone: mitaka-2 → mitaka-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.