PEP8 continuation line under/over-indented

Bug #1459514 reported by Accela Zhao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Low
Unassigned
Revision history for this message
Kai Qiang Wu(Kennan) (wkqwu) wrote :

I am not sure what kind of tox version do you use ?

If I run tox -e pep8 not complain anything, And also our magnum have jenkins CI jobs

we not find pep8 failure.

Are you sure use right env ?

Revision history for this message
Tom Cammann (tom-cammann) wrote :

Need to remove E128 and possibly E127 and E126 from the ignored rules in tox.ini to get the tox returning the same error. We use tox -epep8 to run our pep8 tests, but I'm assuming that Accela has used plain pep8 command.

Steven Dake (sdake)
Changed in magnum:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/186388
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=7344fcf2a793069d78055a0bc09a0738d06e361e
Submitter: Jenkins
Branch: master

commit 7344fcf2a793069d78055a0bc09a0738d06e361e
Author: Accela Zhao <email address hidden>
Date: Fri May 29 22:18:48 2015 +0800

    Fix continuation line under/over indented problems

    When you are writing a multiple method invocation (or other similar
    syntax)

    ```
    obj.method(argument1,
               argument2,
               ...)
    ```

    If you put argument1 in the first line, the following lines should have
    the same hanging distance to argument1.

    If you put argument1 in the second line, the hanging distance should
    always be four.

    ```
    obj.method(
        argument1,
        argument2,
        ...
    )
    ```

    Otherwise PEP8 would complain for continuation line under/over indented
    problems. See below for more details

    https://www.python.org/dev/peps/pep-0008/#indentation

    This patch fixes all the continuation line indentation problems and
    enables related checks in tox.ini.

    Closes-bug: #1459514
    Change-Id: I80995c2ae71b817ad78a87ab7c567f0d36112710

Changed in magnum:
status: Confirmed → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.