Add more assert calls for api test cases

Bug #1414829 reported by Guangya Liu (Jay Lau)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Invalid
Wishlist
Deeksha Sachdeva

Bug Description

This is a review comments from https://review.openstack.org/#/c/149867/ , more assert calls are needed for all api test cases.

Changed in magnum:
importance: Undecided → Wishlist
Revision history for this message
Guangya Liu (Jay Lau) (jay-lau-513) wrote :

Ya, I mean, I want to separate one test method to ideally contains one assert call.

for example:

Bad Pattern:

  def test():
     assert_equals(a, b)
     assert_equals(c, d)

Good Pattern:

   def test_a_b():
     assert_equals(a, b)

  def test_c_d():
     assert_equals(c, d)

Revision history for this message
Guangya Liu (Jay Lau) (jay-lau-513) wrote :

The above is comments from Yuanying for review https://review.openstack.org/#/c/149867/

Revision history for this message
Adrian Otto (aotto) wrote :

Jay, is it okay if I assign you this bug?

Changed in magnum:
assignee: nobody → Jay Lau (jay-lau-513)
Revision history for this message
Guangya Liu (Jay Lau) (jay-lau-513) wrote :

Sure ;-)

Revision history for this message
Adrian Otto (aotto) wrote :

Thanks Jay!

Changed in magnum:
status: New → Triaged
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
Changed in magnum:
assignee: Jay Lau (jay-lau-513) → Deeksha Sachdeva (sachdevadeeksha5)
Revision history for this message
yatin (yatinkarel) wrote :

@Deeksha are you working on this bug, if not i can work on this.

Changed in magnum:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.