products stock export unnecessary for ALL unchanged products

[youngi]

exporting products stock is only needed for products whose quantities have changed.
we are planning for exporting stock quantities every couple of orders placed in order to keep magento updated with quantites sold through the pos...exporting all stock for unchanged products is unnecessary

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

yes, you are absolutely right, I believed we did it but not yet...
My plan was to search in the stock moves newer than the last update time, if there is no move, then we skip the inventory level update.

Sorry about that one and thanks for reporting, we will implement it soon.

[youngi (youngilaboungi)]

great.
also currently in my test,since the stock quantity updated is according to the warehouse related to the shop, I only gave stock values for few products. their stock was exported fine, but all the rest of the products that are not actually in this warehouse were exported to magento as quantity 0...I think this should be fixed, we should not update quantity of an item not in warehouse

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Youngi, (and the others from the list I added in copy) a few comments:

Actually what we currently do is:

A) when clicking 'export catalog' it exports all products that changed since last export and export their inventory level, meaning that yes it will export 0 for all catalog products that changed but never got in stock (typical at first export to Magento). It will however also MISS to export products whose stock changed but whose product sheet didn't change, which is definitely a bug!!!!

B) if you click on "export stock levels only", it will indeed exports all products whose stock level changed (meaning it will forget no product unlike A) and only export products that have been moved since last inventory export.
Now I agree with your last comment: it will export those stocks levels even if the move occurred somewhere else than the involved warehouse. Well my take was that: that would generate few useless export in general while catching exactly the right moves was not completely trivial. For instance we should trigger the inventory export if you move a product to a warehouse sub-location, so at least we should be able to detect that kind of moves from the others (recursive check).

I'm not sure we will fix B) for now as all what it would do is only a few useless requests for now (unless you contribute the fix).

However, we will fix the bug I mentioned in A). For that, I suggest we stop exporting stock levels along with the product sheet systematically. Instead, at the end of the "export catalog feature", we would just trigger the "export inventory levels only" action that would complete the export by exporting the product inventory levels for products that have been moved since last inventory export. However, in a first moment, I'll not go into checking where the product have been moved, that would be a welcome improvement to minimize the request to the bare minimum, but we have limited resources for this fro now and I consider it medium priority only.

What do you think?

Raphaël Valyi
http://www.akretion.com

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Youngi, (and the others from the list I added in copy) a few comments:

Actually what we currently do is:

A) when clicking 'export catalog' it exports all products that changed since
last export and export their inventory level, meaning that yes it will
export 0 for all catalog products that changed but never got in stock
(typical at first export to Magento). It will however also MISS to export
products whose stock changed but whose product sheet didn't change, which is
definitely a bug!!!!

B) if you click on "export stock levels only", it will indeed exports all
products whose stock level changed (meaning it will forget no product unlike
A) and only export products that have been moved since last inventory
export.
Now I agree with your last comment: it will export those stocks levels even
if the move occurred somewhere else than the involved warehouse. Well my
take was that: that would generate few useless export in general while
catching exactly the right moves was not completely trivial. For instance we
should trigger the inventory export if you move a product to a warehouse
sub-location, so at least we should be able to detect that kind of moves
from the others (recursive check).

I'm not sure we will fix B) for now as all what it would do is only a few
useless requests for now (unless you contribute the fix).

However, we will fix the bug I mentioned in A). For that, I suggest we stop
exporting stock levels along with the product sheet systematically. Instead,
at the end of the "export catalog feature", we would just trigger the
"export inventory levels only" action that would complete the export by
exporting the product inventory levels for products that have been moved
since last inventory export. However, in a first moment, I'll not go into
checking where the product have been moved, that would be a welcome
improvement to minimize the request to the bare minimum, but we have limited
resources for this fro now and I consider it medium priority only.

What do you think?

Raphaël Valyi
http://www.akretion.com

On Tue, Dec 22, 2009 at 8:42 AM, youngi <email address hidden> wrote:

> great.
> also currently in my test,since the stock quantity updated is according to
> the warehouse related to the shop, I only gave stock values for few
> products. their stock was exported fine, but all the rest of the products
> that are not actually in this warehouse were exported to magento as quantity
> 0...I think this should be fixed, we should not update quantity of an item
> not in warehouse
>
> --
> products stock export unnecessary for ALL unchanged products
> https://bugs.launchpad.net/bugs/499305
> You received this bug notification because you are subscribed to Magento
> Open ERP Connector.
>
> Status in Magento Open ERP Connector: Confirmed
>
> Bug description:
> exporting products stock is only needed for products whose quantities have
> changed.
> we are planning for exporting stock quantities every couple of orders
> placed in order to keep magento updated with quantites sold through the
> pos...exporting all stock for unchanged products is unnecessary
>
>
>

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello,

so I did what I explained previously in rev #280. Moreover, at first inventory export, there is no last inventory export date yet, so previously we would have exported all the 0 inventory level, now export only those who have some related moves already.
Makes sure you also update your last stable extra addons 5.0 branch too.