Magento OpenERP Connector

Importing Guest-Orders is not possible (KeyError: 'shop_id' in create_onfly_partner on line 387)

Bug #1054059 reported by Erik Miers
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Magento OpenERP Connector
Fix Released
Undecided
Unassigned

Bug Description

Hi, I'm using oerp6.1-stable (rev 677)

In my magento-shop (1.6.0.0) we have a module (Camiloo) that imports orders from Amazon to Magento.
When I try to import these orders to openERP I get the following error.

Thanks for you help.

Client Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/common/http.py", line 180, in dispatch
    response["result"] = method(controller, self, **self.params)
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/controllers/main.py", line 1052, in call_button
    action = self.call_common(req, model, method, args, domain_id, context_id)
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/controllers/main.py", line 996, in call_common
    return self._call_kw(req, model, method, args, {})
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/controllers/main.py", line 1010, in _call_kw
    return getattr(req.session.model(model), method)(*args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/common/openerplib/main.py", line 250, in proxy
    args, kw)
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/common/openerplib/main.py", line 117, in proxy
    result = self.connector.send(self.service_name, method, *args)
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/common/http.py", line 608, in send
    raise xmlrpclib.Fault(openerp.tools.exception_to_unicode(e), formatted_info)

Server Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/openerp/addons/web/common/http.py", line 593, in send
    return openerp.netsvc.dispatch_rpc(service_name, method, args)
  File "/usr/lib/pymodules/python2.6/openerp/netsvc.py", line 360, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "/usr/lib/pymodules/python2.6/openerp/service/web_services.py", line 586, in dispatch
    res = fn(db, uid, *params)
  File "/usr/lib/pymodules/python2.6/openerp/osv/osv.py", line 167, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "/usr/lib/pymodules/python2.6/openerp/osv/osv.py", line 121, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/usr/lib/pymodules/python2.6/openerp/osv/osv.py", line 164, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_sale_multichannels/wizard/import_order.py", line 41, in import_order
    self.pool.get('sale.order')._import_one_resource(cr, uid, external_session, wizard.order_number, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/external_osv.py", line 638, in _import_one_resource
    res = self._record_one_external_resource(cr, uid, external_session, resources, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/decorator.py", line 49, in wrapped
    return func(self, cr, uid, argument, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/magentoerpconnect/sale.py", line 432, in _record_one_external_resource
    res = super(sale_order, self)._record_one_external_resource(cr, uid, external_session, resource, defaults=defaults, mapping=mapping, mapping_id=mapping_id, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/decorator.py", line 110, in wrapper
    return func(self, cr, uid, external_session, resource, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_sale_multichannels/sale.py", line 565, in _record_one_external_resource
    order_mapping=mapping[mapping_id], context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_sale_multichannels/sale.py", line 549, in check_if_order_exist
    context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/decorator.py", line 49, in wrapped
    return func(self, cr, uid, argument, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/magentoerpconnect/sale.py", line 411, in _transform_one_resource
    defaults = self.create_onfly_partner(cr, uid, external_session, resource, mapping, defaults, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/magentoerpconnect/sale.py", line 387, in create_onfly_partner
    shop = self.pool.get('sale.shop').browse(cr, uid, defaults['shop_id'], context=context)
KeyError: 'shop_id'

Related branches

lp:~magentoerpconnect-core-editors/magentoerpconnect/oerp7.0-refactor
lp:~openerp-chinese-team/e-commerce-addons/guest-order-bug-fix
Guewen Baconnier @ Camptocamp: Approve
Diff: 29 lines (+3/-2)
1 file modified
base_sale_multichannels/sale.py (+3/-2)
lp:~openerp-chinese-team/magentoerpconnect/guest-order-bug-fix
Sébastien BEAU - http://www.akretion.com: Disapprove
Guewen Baconnier @ Camptocamp: Needs Resubmitting
Diff: 35 lines (+8/-6)
1 file modified
magentoerpconnect/sale.py (+8/-6)
lp:~sebastien.beau/magentoerpconnect/oerp6.1-cleanning
Alexandre Fayolle - camptocamp: Approve (code review, no test)
Guewen Baconnier @ Camptocamp: Needs Fixing (no test, review)
Diff: 4911 lines (+1653/-1559)
65 files modified
magento_product_auto_sku/__openerp__.py (+1/-1)
magento_product_auto_sku/data.xml (+3/-3)
magento_product_auto_sku/product.py (+9/-15)
magento_sku_is_code/__init__.py (+0/-22)
magento_sku_is_code/__openerp__.py (+0/-41)
magento_sku_is_code/product.py (+0/-66)
magento_sku_is_code/product_view.xml (+0/-24)
magentoerpconnect/__openerp__.py (+2/-2)
magentoerpconnect/delivery.py (+6/-4)
magentoerpconnect/delivery_view.xml (+2/-2)
magentoerpconnect/invoice.py (+76/-27)
magentoerpconnect/magerp_core.py (+26/-26)
magentoerpconnect/magerp_core_view.xml (+152/-156)
magentoerpconnect/magerp_data.xml (+10/-10)
magentoerpconnect/magerp_menu.xml (+1/-1)
magentoerpconnect/magerp_osv.py (+67/-64)
magentoerpconnect/partner.py (+49/-49)
magentoerpconnect/partner_view.xml (+2/-6)
magentoerpconnect/product.py (+151/-186)
magentoerpconnect/product_images.py (+25/-19)
magentoerpconnect/product_images_view.xml (+21/-21)
magentoerpconnect/product_links.py (+6/-10)
magentoerpconnect/product_view.xml (+310/-310)
magentoerpconnect/sale.py (+40/-37)
magentoerpconnect/sale_view.xml (+72/-42)
magentoerpconnect/server_tmp.patch (+0/-14)
magentoerpconnect/settings/1.3.2.4/external.mappinglines.template.csv (+53/-53)
magentoerpconnect/settings/1.5.0.0/product.category/external.mappinglines.template.csv (+8/-8)
magentoerpconnect/settings/1.5.0.0/product/external.mappinglines.template.csv (+1/-1)
magentoerpconnect/settings/1.5.0.0/res.partner.address/external.mappinglines.template.csv (+13/-2)
magentoerpconnect/settings/1.5.0.0/res.partner/external.mappinglines.template.csv (+2/-1)
magentoerpconnect/settings/1.5.0.0/sale.order.line/external.mappinglines.template.csv (+3/-2)
magentoerpconnect/settings/1.5.0.0/sale.order/external.mappinglines.template.csv (+14/-3)
magentoerpconnect/stock.py (+4/-7)
magentoerpconnect/wizard/open_product_by_attribut_set.py (+5/-7)
magentoerpconnect_bundle/__openerp__.py (+3/-3)
magentoerpconnect_bundle/product.py (+9/-16)
magentoerpconnect_bundle/product_view.xml (+31/-31)
magentoerpconnect_bundle/sale.py (+4/-6)
magentoerpconnect_bundle/sale_bundle_product.py (+6/-16)
magentoerpconnect_bundle/sale_bundle_product_view.xml (+14/-14)
magentoerpconnect_bundle_split/__openerp__.py (+1/-1)
magentoerpconnect_bundle_split/sale.py (+16/-21)
magentoerpconnect_bundle_split/stock.py (+8/-14)
magentoerpconnect_customer_fiscal_category/__openerp__.py (+2/-2)
magentoerpconnect_customer_fiscal_category/settings/1.5.0.0/external.mappinglines.template.csv (+2/-7)
magentoerpconnect_init_stock/__openerp__.py (+1/-1)
magentoerpconnect_init_stock/product.py (+2/-5)
magentoerpconnect_magento_invoice/__init__.py (+28/-0)
magentoerpconnect_magento_invoice/__openerp__.py (+44/-0)
magentoerpconnect_magento_invoice/account.py (+35/-0)
magentoerpconnect_openerp_invoice/__init__.py (+1/-5)
magentoerpconnect_openerp_invoice/__openerp__.py (+9/-5)
magentoerpconnect_openerp_invoice/external_referential.py (+33/-0)
magentoerpconnect_openerp_invoice/external_referential_view.xml (+22/-0)
magentoerpconnect_openerp_invoice/invoice.py (+57/-24)
magentoerpconnect_partner_surname/__init__.py (+21/-0)
magentoerpconnect_partner_surname/__openerp__.py (+43/-0)
magentoerpconnect_partner_surname/settings/1.5.0.0/res.partner.address/external.mappinglines.template.csv (+3/-0)
magentoerpconnect_payment/__openerp__.py (+1/-1)
magentoerpconnect_payment/payment_type.py (+6/-8)
magentoerpconnect_payment/sale.py (+18/-20)
magentoerpconnect_product_variant/__openerp__.py (+3/-3)
magentoerpconnect_product_variant/product.py (+20/-38)
magentoerpconnect_product_variant/product_view.xml (+76/-76)
lp:~extra-addons-commiter/e-commerce-addons/oerp6.1-stable
Revision history for this message
Kristofer Eriksson (kristofer-eriksson) wrote :

Hi all,

am seeing this exception when trying to import standard Magento guest orders. To me it seems to be a more generic problem, not related to orders being imported into Magento previously.

Revision history for this message
Willi Kreißl (6-willx-h) wrote :

Hey Guys!

I have the same exeption when importing guest orders.

In debug mode I checked whats wrong.
In create_onfly_partner the variable "defaults" is empty when it is a guest order and it tries to read "shop_id" from it in line 387 (defaults['shop_id'])
Line: shop = self.pool.get('sale.shop').browse(cr, uid, defaults['shop_id'], context=context)

Trace:
Server Traceback (most recent call last):
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\web\common\http.py", line 593, in send
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\netsvc.py", line 360, in dispatch_rpc
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\service\web_services.py", line 586, in dispatch
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 167, in execute_kw
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 121, in wrapper
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 176, in execute
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 164, in execute_cr
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\report.py", line 343, in retry
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\decorator.py", line 49, in wrapped
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\magentoerpconnect\sale.py", line 432, in _record_one_external_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\decorator.py", line 130, in wrapper
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_sale_multichannels\sale.py", line 565, in _record_one_external_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_sale_multichannels\sale.py", line 549, in check_if_order_exist
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\decorator.py", line 49, in wrapped
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\magentoerpconnect\sale.py", line 411, in _transform_one_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\magentoerpconnect\sale.py", line 387, in create_onfly_partner
KeyError: 'shop_id'

Any idea why defaults is empty?

Willi Kreißl (6-willx-h)
Changed in magentoerpconnect:
status: New → Confirmed
Revision history for this message
Willi Kreißl (6-willx-h) wrote :

I've tried to add the shop_id manually before it is reading defaults by adding defaults['shop_id'] = 1 in sale.py on line 382.

Looks like this:
if not defaults: defaults={}
defaults['shop_id'] = 1
local_defaults = defaults.copy()

Now the function create_onfly_partner() works but it throws in another function an exception now:

Server Traceback (most recent call last):
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\web\common\http.py", line 593, in send
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\netsvc.py", line 360, in dispatch_rpc
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\service\web_services.py", line 586, in dispatch
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 167, in execute_kw
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 121, in wrapper
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 176, in execute
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\.\openerp\osv\osv.py", line 164, in execute_cr
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\report.py", line 343, in retry
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\decorator.py", line 49, in wrapped
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\magentoerpconnect\sale.py", line 435, in _record_one_external_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\decorator.py", line 130, in wrapper
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_sale_multichannels\sale.py", line 565, in _record_one_external_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_sale_multichannels\sale.py", line 549, in check_if_order_exist
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\decorator.py", line 49, in wrapped
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\magentoerpconnect\sale.py", line 414, in _transform_one_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\magentoerpconnect\sale.py", line 392, in create_onfly_partner
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\external_osv.py", line 686, in _record_one_external_resource
  File "C:\Program Files (x86)\OpenERP 6.1-20120816-233414\Server\server\openerp\addons\base_external_referentials\external_osv.py", line 1379, in _transform_one_resource
  File "<string>", line 1, in <module>
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

This happens when defaults['shop_id'] is manually set.

Willi Kreißl (6-willx-h)
summary: - cannot import orders made on amazon
+ Importing Guest-Orders is not possible
Willi Kreißl (6-willx-h)
summary: - Importing Guest-Orders is not possible
+ Importing Guest-Orders is not possible (KeyError: 'shop_id' in
+ create_onfly_partner on line 387)
Revision history for this message
Erik Miers (p949b) wrote :

Any news on this one ?
workaround ?

Revision history for this message
Edgar (r-christ) wrote :

The same here, any solutions?

Revision history for this message
Willi Kreißl (6-willx-h) wrote :

At the moment a did not find any usable solution that worked always fine and I think I'll give this connector up soon...
After fixing this bug there will be so much more bugs, it is not usable in a productive environment at the moment.

Revision history for this message
Kristofer Eriksson (kristofer-eriksson) wrote :

@Willi: hope this is just a temporary down, I do feel the same sometimes. Nevertheless, it seems like you had a go at it, what did you actually try to fix it, and what did not work well?

Regards

Kristofer

Revision history for this message
Joshua Jan(SHINEIT) (joshuajan) wrote :

hello all ,
     I have try to fix it. This is the patch.
     Regards
Joshua

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Joshua,

good work! Can you make it into a set of proper branches for the respective projects? You can then propose each of the branches for review by the core developers.

Cheers,
Stefan.

Revision history for this message
Joshua Jan(SHINEIT) (joshuajan) wrote :

Hi Stefan,
     Thanks for you advice. I have already make two proper for this bug.
Cheers,
Joshua

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Joshua, thanks for preparing the branches. Hopefully they will be merged soon.

Revision history for this message
Erik Miers (p949b) wrote :

Hi Joshua, thanks for your patch.

I tried it out, but now I'm presented with this MappingError:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/decorator.py", line 130, in wrapper
    response = func(self, import_cr, uid, external_session, resource, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_sale_multichannels/sale.py", line 571, in _record_one_external_resource
    defaults=defaults, mapping=mapping, mapping_id=mapping_id, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/external_osv.py", line 686, in _record_one_external_resource
    vals = self._transform_one_resource(cr, uid, external_session, 'from_external_to_openerp', resource, mapping=mapping, mapping_id=mapping_id, defaults=defaults, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/decorator.py", line 49, in wrapped
    return func(self, cr, uid, argument, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/magentoerpconnect/sale.py", line 417, in _transform_one_resource
    previous_result=previous_result, defaults=defaults, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/external_osv.py", line 1409, in _transform_one_resource
    vals = self._transform_sub_mapping(cr, uid, external_session, convertion_type, resource, vals, sub_mapping_list, mapping, mapping_id, mapping_line_filter_ids=mapping_line_filter_ids, defaults=defaults, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/external_osv.py", line 1582, in _transform_sub_mapping
    lines = sub_mapping_obj._transform_resources(*transform_args, **transform_kwargs)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/external_osv.py", line 1301, in _transform_resources
    previous_result=result, defaults=defaults, context=context))
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_sale_multichannels/sale.py", line 881, in _transform_one_resource
    previous_result=previous_result, defaults=defaults, context=context)
  File "/usr/lib/pymodules/python2.6/openerp/addons/base_external_referentials/external_osv.py", line 1383, in _transform_one_resource
    raise MappingError(e, mapping_line['name'], self._name)
MappingError: u'the mapping line : price for the object sale.order.line have an error : float() argument must be a string or a number'

Any ideas on that?

Revision history for this message
Erik Miers (p949b) wrote :

Ok, I solved this Mapping Error.

The problem is, that the field "base_row_total_incl_tax" is null (None) for all order-items which I have imported from Amazon to my Magento store. But this field is required for the particular ma mapping-function for the "price" field on Sale Order Line

Which is this:

result=[
('price_unit_tax_included', (float(resource['base_row_total_incl_tax']))/float(resource['qty_ordered'])),
('price_unit_tax_excluded', (float(resource['base_row_total']))/float(resource['qty_ordered'])),
('tax_rate', float(resource['base_row_total']) and (float(resource['base_row_total_incl_tax'])/float(resource['base_row_total'])-1)),
]

So two approaches to solve this:

First:
 Change the mapping function to don't use "base_row_total_incl_tax" like this:

result=[
('price_unit_tax_included', float(resource['price_incl_tax'])),
('price_unit_tax_excluded', (float(resource['base_row_total']))/float(resource['qty_ordered'])),
('tax_rate', float(resource['base_row_total']) and ((float(resource['price_incl_tax'])*float(resource['qty_ordered']))/float(resource['base_row_total'])-1)),
]

I don't know if this is save for all use-cases, so someone should have a look at it.

Second:
 Change Magento code to automatically calculate base_row_total_incl_tax on every order (from Amazon) created.
But I haven't looked into the code, yet. So I don't know where to actually do this.
And you would also have to change all previously created orders in the database.

Hope this helps anyone.

Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

Hi this bug have been fix some time ago here was the patch http://bazaar.launchpad.net/~magentoerpconnect-core-editors/magentoerpconnect/oerp6.1-stable/revision/676.2.36

Thanks for reporting the bug. I close it

Changed in magentoerpconnect:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.