virsh calls do not unset locale in MAAS 2.0

[Данило Шеган]

I just upgraded my home MAAS (with virtual machines) to 2.0.0~rc3+bzr5180-0ubuntu2~16.04.1 (upgrade did not go all smoothly, and it was a do-release-upgrade from trusty to xenial, but I haven't kept notes since I needed to get this going), and hit a problem where the new virsh "driver" errored out with

"Unknown state: заустављено"

Unsurprisingly, this is exactly the same thing ("заустављено") I get if I run "virsh -c qemu+ssh://..../system domstate <domain>" from a local system with Serbian locale set, and if I precede that with LC_ALL=C, I instead get "shut off".

Along those lines, http://paste.ubuntu.com/22223426/ fixed it for me and allowed me to move past this issue.

Do note that this is not necessarily enough: LC_*, LANG and LANGUAGE variables have different precedence and this worked for me because I had LANGUAGE=sr and LC_ALL=sr_RS.utf8 set.

[Данило Шеган (danilo)]

I've hit this again upgrading to MAAS 2.1 so I've proposed a fix along with the test. Hopefully it helps.

I've hit issues trying to 'make build' inside MAAS trunk on xenial: https://pastebin.canonical.com/169926/ — this seems to come from an ipdb/ipython dependency, so commenting that out works https://pastebin.canonical.com/169925/. Without wanting to spend more time investigating if it's a problem with upstream dep or MAAS itself, I've left it at that.