Kernel opts tagging feature missing completely

[Jeff Marcom]

The Global Kernel Parameters UI field and kernel_opts tagging fields are missing completely from MAAS/1.2 and the daily maintainer ppa for quantal.

kernel_opts variable is currently missing from /src/maaserver/models/tag.py

Fix:
@@ -89,6 +89,8 @@
         tag.
     :ivar comment: A long-form description for humans about what this tag is
         trying to accomplish.
+ :ivar kernel_opts: Optional kernel command-line parameters string to be
+ used in the PXE config for nodes with this tags.
     :ivar objects: The :class:`TagManager`.
     """

@@ -101,6 +103,7 @@
                      validators=[RegexValidator(_tag_name_regex)])
     definition = TextField(blank=True)
     comment = TextField(blank=True)
+ kernel_opts = TextField(blank=True, null=True)

     objects = TagManager()

After the above patch is applied I can now assign a valid kernel_opts parameter to a named tag:

>>> maasserver.models.Tag.objects.values()
[{'comment': u'', 'definition': u'', 'updated': datetime.datetime(2013, 1, 15, 18, 44, 1, 468734), 'name': u'precise_201001-4955', 'created': datetime.datetime(2013, 1, 15, 18, 44, 1, 356274), 'kernel_opts': u'url=http://10.153.104.237/preseeds/01-00-25-64-82-4b-13 boot=casper initrd=initrd.lz netboot=nfs nfsroot=10.153.104.237:/var/www/rsync.cdimage.ubuntu.com/cdimage/releases/precise-desktop-amd64 automatic-ubiquity', 'id': 1}]

This of course does not fix the missing kernel_opts values in the MAAS UI

[Raphaël Badin (rvb)]

This apparently was present in the 1.2 branch and then was removed by https://code.launchpad.net/~jameinel/maas/1.2-remove-kernel-opts/+merge/133425. The commit message says:
"""This removes the recent patches to add kernel_opts to the 1.2 branch.
We'll land it instead on trunk, and then it will get backported in the future once a bugfix only SRU was done."""

I'll ask jam or gz to comment on this.

[Raphaël Badin (rvb)]

rvba | jam: mgz Hey guys, would you mind having a look at bug #1100091 ?
ubot5 | bug 1100091 in MAAS 1.2 "Kernel opts tagging feature missing completely" [Undecided,New] https://launchpad.net/bugs/1100091
mgz | rvba: indeed, we were putting it on 1.2 but you guys were trying to do a release from that so we took it off
mgz | if it's now wanted in a 1.2 release, it will need backporting

I guess we need a design decision here, is this a 1.2 feature?

[John A Meinel (jameinel)]

Julian asked us to not merge it to the 1.2 branch, because he wanted to do a bugfix only SRU. Which was then followed up with deciding to not put this into 1.2 after all.

[Julian Edwards (julian-edwards)]

Hi Jeff

Sorry, it hadn't registered in my brain that you were talking about 1.2 specifically. Generally speaking, the new features were going into trunk (for raring) and 1.2 only had bug fixes. The 1.2 branch works on quantal if you want me to do a build for you on there.

I'll mark this wishlist for now, please talk to me if you need this in 1.2.

J