Start Node button does not allocate node
Bug #987585 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
| 1.0 |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
Bug Description
Reporting on behalf of Francis - apparently the start node button starts the node up but leaves it in the READY state in MAAS, when it should be ALLOCATED.
Related branches
lp:~jtv/maas/pre-987585-get_oauth_token
- Raphaël Badin (community): Approve
-
Diff: 214 lines (+88/-36)3 files modifiedsrc/maasserver/api.py (+36/-21)
src/maasserver/tests/test_api.py (+51/-8)
src/metadataserver/api.py (+1/-7)
lp:~jtv/maas/pre-987585-save-node-acquire-release
- Raphaël Badin (community): Approve
-
Diff: 38 lines (+2/-2)2 files modifiedsrc/maasserver/api.py (+0/-2)
src/maasserver/models/__init__.py (+2/-0)
lp:~jtv/maas/pre-987585-cosmetics-and-test-helper
- Gavin Panella (community): Approve
-
Diff: 111 lines (+25/-17)4 files modifiedsrc/maasserver/forms.py (+8/-8)
src/maasserver/tests/test_forms.py (+1/-1)
src/maasserver/tests/test_views_nodes.py (+13/-4)
src/maasserver/views/nodes.py (+3/-4)
lp:~jtv/maas/bug-987585
- Gavin Panella (community): Approve
-
Diff: 238 lines (+81/-22)4 files modifiedsrc/maasserver/forms.py (+28/-8)
src/maasserver/tests/test_forms.py (+16/-2)
src/maasserver/tests/test_views_nodes.py (+20/-11)
src/maasserver/views/nodes.py (+17/-1)
lp:~jtv/maas/backport-987585
- Raphaël Badin (community): Approve
-
Diff: 267 lines (+83/-26)6 files modifiedsrc/maasserver/api.py (+14/-0)
src/maasserver/forms.py (+26/-14)
src/maasserver/models.py (+2/-0)
src/maasserver/tests/test_api.py (+24/-0)
src/maasserver/tests/test_forms.py (+16/-2)
src/maasserver/tests/test_views.py (+1/-10)
- Launchpad code reviewers: Pending requested
-
Diff: 918 lines (+737/-0) (has conflicts)5 files modifiedsrc/maasserver/api.py (+16/-0)
src/maasserver/forms.py (+58/-0)
src/maasserver/tests/test_api.py (+38/-0)
src/maasserver/tests/test_forms.py (+28/-0)
src/maasserver/tests/test_views.py (+597/-0)
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in maas: | |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| status: | Triaged → In Progress |
| summary: |
- Start Node button leaves node in READY + Start Node button does not allocate node |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Apparently this implies that the “Start node” button was meant to allocate a node and start it. The original spec implied that it should just start the node, and that's why it currently requires Edit privileges on the node.
This means that on Ready nodes, the button should require only View privileges and it should allocate the node. It may be slightly confusing that an admin starting somebody else's Allocated node won't change its allocation, but an admin (or anyone else) starting a Ready node will also acquire it in the process. I'll change the feedback message so that this distinction is clear.
A minor complication is that the allocation process needs the user's token. The action method is passed the requesting user and the affected node, but not the web request.