maas-import-isos ignores http_proxy

[Julian Edwards]

This makes it impossible to download the ISOs from a proxied LAN.

You can see that it fails by doing the following:

export http_proxy=http://example.com/
sudo maas-import-isos

And you get the output:
--2012-04-30 10:25:56-- http://archive.ubuntu.com/ubuntu/dists/precise-updates/main/installer-amd64/current/images/netboot/mini.iso
Resolving archive.ubuntu.com (archive.ubuntu.com)... 91.189.92.151, 91.189.92.152, 91.189.92.153, ...
Connecting to archive.ubuntu.com (archive.ubuntu.com)|91.189.92.151|:80... connected.
...

which means it ignored the proxy setting.

Since ultimately the script uses wget, this should really work.

[Jeroen T. Vermeulen (jtv)]

The “sudo” would discard the setting you just exported. Does it behave as expected if you do it like this?

$ sudo env http_proxy=http://example.com/ maas-import isos

[Jeroen T. Vermeulen (jtv)]

Ahem. Typo. Correction:

$ sudo env http_proxy=http://example.com/ maas-import-isos

[Scott Moser (smoser)]

Jeroen is correct. sometime between 10.04 and 12.04 (i think) sudo started being more annoying about filtering environment variables. Note, though, you do no need the 'env' command, as sudo does it itself:

 sudo http_proxy=..... maas-import-isos

Additionally, you could actually just add:
  export http_proxy=http://example.com
to the /etc/maas/import_isos config file.

[Shannon McFarland (shmcfarl)]

Nice work guys!!! I actually just ran it as root and it worked instantly after doing an export. In the future I will probably pu tit in the import_isos file as Scott stated.

Thanks again!

[Julian Edwards (julian-edwards)]

Jeroen, I suggest you update the documentation on how to set a proxy. There's no actual fix to code here.

[drolfe (drolfe)]

Use Sudo -E

From the sudo man page

The -E (preserve environment) option indicates to the security policy that the user wishes to preserve their existing environment variables. The security policy may return an error if the -E option is specified and the user does not have permission to preserve the environment.

[Jeroen T. Vermeulen (jtv)]

I didn't use the -E option because it has more far-reaching consequences and so might do collateral damage. But the bit about the error is another reason not to do it.